[jira] [Commented] (HBASE-15186) HBASE-15158 Preamble: fix findbugs, add javadoc and some util

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122918#comment-15122918 ] 

Anoop Sam John commented on HBASE-15186:
----------------------------------------


{code}
if (cell.getTagsLength() <= 0) {
234	      return tags;
235	    }
236	    Iterator<Tag> itr = CellUtil.tagsIterator(cell);
237	    if (itr == EMPTY_TAGS_ITR) {
238	      // If no Tags, return early.
239	      return tagsOrNull;
240	    }
{code}
This check of itr being EMPTY_TAGS_ITR is redundant .  Either we can do this or getTagsLength() check above..  I prefer the second one as we can avoid avoid one more parsing of tags length.   So we can just avoid the cell.getTagsLength() <= 0   check.

Javadoc for upsert(Cell cell, long readpoint)
Why to remove the cell param?  

Looks good otherwise.

> HBASE-15158 Preamble: fix findbugs, add javadoc and some util
> -------------------------------------------------------------
>
>                 Key: HBASE-15186
>                 URL: https://issues.apache.org/jira/browse/HBASE-15186
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>         Attachments: subpatch.patch
>
>
> Break up the HBASE-15158 patch. Here is the first piece. Its a bunch of findbugs fixes, a bit of utility for tag-handling (to be exploited in later patches), some clarifying comments and javadoc (and javadoc fixes), cleanup of a some Region API. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)