You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "pnicolucci (via GitHub)" <gi...@apache.org> on 2024/03/08 17:39:10 UTC
[PR] Remove security manager [myfaces]
pnicolucci opened a new pull request, #680:
URL: https://github.com/apache/myfaces/pull/680
https://issues.apache.org/jira/browse/MYFACES-4653
1. I've removed all the references to the SecurityManager and associated APIs in both the API and IMPL code.
2. I've cleaned up the SPI in general to have more consistent naming conventions for some variables.
3. I removed one comment in `DefaultFaceletFactory` that didn't look to be necessary any longer.
Please give this one a good review to ensure I didn't miss anything as there are many changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4653: Remove SecurityManager and assocaited APIs [myfaces]
Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #680:
URL: https://github.com/apache/myfaces/pull/680#issuecomment-1986140168
OK cool so this should be forward ported to 5.x once its accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4653: Remove SecurityManager and assocaited APIs [myfaces]
Posted by "pnicolucci (via GitHub)" <gi...@apache.org>.
pnicolucci commented on PR #680:
URL: https://github.com/apache/myfaces/pull/680#issuecomment-1986145309
> OK cool so this should be forward ported to 5.x once its accepted.
@melloware I can create a PR for 5.x once I merge here. Let me add @tandraschko and @volosied as reviewers as well to make sure they don't have any comment and I'll plan to merge this on Monday if no further feedback!
Thanks for the quick review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4653: Remove SecurityManager and assocaited APIs [myfaces]
Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #680:
URL: https://github.com/apache/myfaces/pull/680#issuecomment-1986132931
So is `AccessController.doPrivileged` just completely not needed anymore in JDK17?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4653: Remove SecurityManager and associated APIs [myfaces]
Posted by "pnicolucci (via GitHub)" <gi...@apache.org>.
pnicolucci merged PR #680:
URL: https://github.com/apache/myfaces/pull/680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4653: Remove SecurityManager and assocaited APIs [myfaces]
Posted by "pnicolucci (via GitHub)" <gi...@apache.org>.
pnicolucci commented on PR #680:
URL: https://github.com/apache/myfaces/pull/680#issuecomment-1986136436
> So is `AccessController.doPrivileged` just completely not needed anymore in JDK17?
It is still in Java17 and accessible. One theme of Jakarta EE11 was to work on removing the references to the SecurityManager in anticipation of it being removed in a future Java version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org