You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by db...@apache.org on 2007/10/03 03:16:14 UTC
svn commit: r581456 -
/geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
Author: dblevins
Date: Tue Oct 2 18:16:13 2007
New Revision: 581456
URL: http://svn.apache.org/viewvc?rev=581456&view=rev
Log:
Fix for GERONIMO-3199: Prefix ear name in deployment-id to make it unique
Set jndiname format to {ejbName}{interfaceType.annotationName}
Setup jndi name binding of non-javaee clients to not fail a deployment if a name is taken (just logs an ERROR as usual).
Modified:
geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
Modified: geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java?rev=581456&r1=581455&r2=581456&view=diff
==============================================================================
--- geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java (original)
+++ geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java Tue Oct 2 18:16:13 2007
@@ -107,10 +107,11 @@
System.setProperty("duct tape","");
System.setProperty("admin.disabled", "true");
System.setProperty("openejb.logger.external", "true");
-
- setDefaultProperty("openejb.deploymentId.format", "{moduleId}/{ejbName}");
+ System.setProperty("openejb.jndiname.failoncollision", "false");
+
+ setDefaultProperty("openejb.deploymentId.format", "{appId}/{moduleId}/{ejbName}");
setDefaultProperty("openejb.jndiname.strategy.class", "org.apache.openejb.assembler.classic.JndiBuilder$TemplatedStrategy");
- setDefaultProperty("openejb.jndiname.format", "{deploymentId}/{interfaceClass}");
+ setDefaultProperty("openejb.jndiname.format", "{ejbName}{interfaceType.annotationName}");
System.setProperty("openejb.naming", "xbean");
if (transactionManager == null) {
Re: svn commit: r581456 - /geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
Posted by Joe Bohn <jo...@earthlink.net>.
David,
This change and the subsequent correction of it are causing TCK failures
due to failures when looking up the JDNIContext.lookup failures from the
client. See the tck list for details.
Joe
dblevins@apache.org wrote:
> Author: dblevins
> Date: Tue Oct 2 18:16:13 2007
> New Revision: 581456
>
> URL: http://svn.apache.org/viewvc?rev=581456&view=rev
> Log:
> Fix for GERONIMO-3199: Prefix ear name in deployment-id to make it unique
> Set jndiname format to {ejbName}{interfaceType.annotationName}
> Setup jndi name binding of non-javaee clients to not fail a deployment if a name is taken (just logs an ERROR as usual).
>
> Modified:
> geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
>
> Modified: geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java?rev=581456&r1=581455&r2=581456&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java (original)
> +++ geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java Tue Oct 2 18:16:13 2007
> @@ -107,10 +107,11 @@
> System.setProperty("duct tape","");
> System.setProperty("admin.disabled", "true");
> System.setProperty("openejb.logger.external", "true");
> -
> - setDefaultProperty("openejb.deploymentId.format", "{moduleId}/{ejbName}");
> + System.setProperty("openejb.jndiname.failoncollision", "false");
> +
> + setDefaultProperty("openejb.deploymentId.format", "{appId}/{moduleId}/{ejbName}");
> setDefaultProperty("openejb.jndiname.strategy.class", "org.apache.openejb.assembler.classic.JndiBuilder$TemplatedStrategy");
> - setDefaultProperty("openejb.jndiname.format", "{deploymentId}/{interfaceClass}");
> + setDefaultProperty("openejb.jndiname.format", "{ejbName}{interfaceType.annotationName}");
>
> System.setProperty("openejb.naming", "xbean");
> if (transactionManager == null) {
>
>
>
Re: svn commit: r581456 - /geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
Posted by Joe Bohn <jo...@earthlink.net>.
David,
This change and the subsequent correction of it are causing TCK failures
due to failures when looking up the JDNIContext.lookup failures from the
client. See the tck list for details.
Joe
dblevins@apache.org wrote:
> Author: dblevins
> Date: Tue Oct 2 18:16:13 2007
> New Revision: 581456
>
> URL: http://svn.apache.org/viewvc?rev=581456&view=rev
> Log:
> Fix for GERONIMO-3199: Prefix ear name in deployment-id to make it unique
> Set jndiname format to {ejbName}{interfaceType.annotationName}
> Setup jndi name binding of non-javaee clients to not fail a deployment if a name is taken (just logs an ERROR as usual).
>
> Modified:
> geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
>
> Modified: geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java
> URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java?rev=581456&r1=581455&r2=581456&view=diff
> ==============================================================================
> --- geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java (original)
> +++ geronimo/server/branches/2.0/modules/geronimo-openejb/src/main/java/org/apache/geronimo/openejb/OpenEjbSystemGBean.java Tue Oct 2 18:16:13 2007
> @@ -107,10 +107,11 @@
> System.setProperty("duct tape","");
> System.setProperty("admin.disabled", "true");
> System.setProperty("openejb.logger.external", "true");
> -
> - setDefaultProperty("openejb.deploymentId.format", "{moduleId}/{ejbName}");
> + System.setProperty("openejb.jndiname.failoncollision", "false");
> +
> + setDefaultProperty("openejb.deploymentId.format", "{appId}/{moduleId}/{ejbName}");
> setDefaultProperty("openejb.jndiname.strategy.class", "org.apache.openejb.assembler.classic.JndiBuilder$TemplatedStrategy");
> - setDefaultProperty("openejb.jndiname.format", "{deploymentId}/{interfaceClass}");
> + setDefaultProperty("openejb.jndiname.format", "{ejbName}{interfaceType.annotationName}");
>
> System.setProperty("openejb.naming", "xbean");
> if (transactionManager == null) {
>
>
>