[jira] [Commented] (CASSANDRA-12143) NPE when trying to remove purgable tombstones from result

["Sylvain Lebresne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364285#comment-15364285 ] 

Sylvain Lebresne commented on CASSANDRA-12143:
----------------------------------------------

[~michaelsembwever] the fix looks obviously good, but would you have a few minutes to also add a unit test to demonstrate the failure?

> NPE when trying to remove purgable tombstones from result
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-12143
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12143
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: mck
>            Assignee: mck
>             Fix For: 2.2.7
>
>         Attachments: 12143-2.2.txt
>
>
> A cluster running 2.2.6 started throwing NPEs.
> (500K exceptions on a node was seen.)
> {noformat}WARN  … AbstractLocalAwareExecutorService.java:169 - Uncaught exception on thread Thread[SharedPool-Worker-5,5,main]: {}
> java.lang.NullPointerException: null{noformat}
> Bisecting this highlighted commit d3db33c008542c7044f3ed8c19f3a45679fcf52e as the culprit, which was a fix for CASSANDRA-11427.
> This commit added a line to "remove purgable tombstones from result" but failed to null check the {{data}} variable first. This variable comes from {{Row.cf}} which is permitted to be null where the CFS has no data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)