[GitHub] [arrow] zeroshade commented on a diff in pull request #34172: GH-34171: [Go][Compute] Implement "Unique" kernel

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #34172:
URL: https://github.com/apache/arrow/pull/34172#discussion_r1106078089


##########
go/arrow/array/util.go:
##########
@@ -272,6 +272,17 @@ func getDictArrayData(mem memory.Allocator, valueType arrow.DataType, memoTable
 			offsets := arrow.Int32Traits.CastFromBytes(buffers[1].Bytes())
 			tbl.CopyOffsetsSubset(startOffset, offsets)
 
+			valuesz := offsets[len(offsets)-1] - offsets[0]
+			buffers[2].Resize(int(valuesz))
+			tbl.CopyValuesSubset(startOffset, buffers[2].Bytes())
+		case arrow.LARGE_BINARY, arrow.LARGE_STRING:

Review Comment:
   Yea, look at lines 294-297 of `vector_hash_test.go` the whole test suite for working with binary/string types gets run with both the LargeBinary and LargeString types also. It's actually how I found this issue in the first place so I could fix it :) haha.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org