You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/05 08:01:58 UTC
[GitHub] sijie commented on a change in pull request #948: ISSUE #947: ZK configs for LocalBookkeeper
sijie commented on a change in pull request #948: ISSUE #947: ZK configs for LocalBookkeeper
URL: https://github.com/apache/bookkeeper/pull/948#discussion_r159824386
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/LocalBookKeeper.java
##########
@@ -280,11 +291,19 @@ static void startLocalBookiesInternal(ServerConfiguration conf,
List<File> bkTmpDirs = null;
try {
if (shouldStartZK) {
- zkTmpDir = IOUtils.createTempDir("zookeeper", dirSuffix);
+ if (null == zkDataDir) {
+ zkTmpDir = IOUtils.createTempDir("zookeeper", dirSuffix);
Review comment:
any reason why you are using two different createTempDir method here? is `IOUtils.createTempDir` not enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services