You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/11 06:54:08 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #7233: [wip][dashboard] After update filter, trigger queries only when charts are…

codecov-io commented on issue #7233: [wip][dashboard] After update filter, trigger queries only when charts are…
URL: https://github.com/apache/incubator-superset/pull/7233#issuecomment-481989917
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7233?src=pr&el=h1) Report
   > Merging [#7233](https://codecov.io/gh/apache/incubator-superset/pull/7233?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/80070d0eafb3eb24dce839a33cdf4bc443468aed?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `36.84%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7233/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7233?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7233      +/-   ##
   ==========================================
   - Coverage   64.93%   64.92%   -0.02%     
   ==========================================
     Files         424      424              
     Lines       20592    20599       +7     
     Branches     2280     2284       +4     
   ==========================================
   + Hits        13372    13374       +2     
   - Misses       7097     7102       +5     
     Partials      123      123
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7233?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ts/src/dashboard/components/gridComponents/Row.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9Sb3cuanN4) | `87.5% <ø> (ø)` | :arrow_up: |
   | [...ts/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWIuanN4) | `68.18% <ø> (ø)` | :arrow_up: |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9DaGFydEhvbGRlci5qc3g=) | `84.84% <ø> (ø)` | :arrow_up: |
   | [...ts/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmRDb21wb25lbnQuanN4) | `100% <ø> (ø)` | :arrow_up: |
   | [...s/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWJzLmpzeA==) | `63.93% <ø> (ø)` | :arrow_up: |
   | [...ts/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZVZpZXdDb250YWluZXIuanN4) | `34.28% <ø> (+0.24%)` | :arrow_up: |
   | [...sets/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9EYXNoYm9hcmRCdWlsZGVyLmpzeA==) | `81.48% <ø> (ø)` | :arrow_up: |
   | [...src/dashboard/components/gridComponents/Column.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9Db2x1bW4uanN4) | `87.87% <ø> (ø)` | :arrow_up: |
   | [.../assets/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9EYXNoYm9hcmRHcmlkLmpzeA==) | `61.11% <ø> (ø)` | :arrow_up: |
   | [...rset/assets/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmQuanN4) | `0% <ø> (ø)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/7233/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7233?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7233?src=pr&el=footer). Last update [80070d0...422d0f7](https://codecov.io/gh/apache/incubator-superset/pull/7233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org