You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/30 18:04:42 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #15285: Fixed #9387: Add State types for tasks and DAGs

potiuk commented on a change in pull request #15285:
URL: https://github.com/apache/airflow/pull/15285#discussion_r661701608



##########
File path: airflow/utils/state.py
##########
@@ -96,17 +127,17 @@ def color_fg(cls, state):
             return 'white'
         return 'black'
 
-    running = frozenset([RUNNING, SENSING])
+    running: FrozenSet[TaskInstanceState] = frozenset([TaskInstanceState.RUNNING, TaskInstanceState.SENSING])

Review comment:
       Yep. I also often do that even if not technically needed to make it explicit. I think code should be much more optimised for reader's time than writer's time to write it ;).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org