You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/04/03 01:00:40 UTC

[kudu-CR] clang-tidy fixes from LLVm 6 

Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9899


Change subject: clang-tidy fixes from LLVm 6
......................................................................

clang-tidy fixes from LLVm 6

Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
---
M src/kudu/common/types.h
M src/kudu/gutil/port.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/util/inline_slice.h
5 files changed, 15 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9899/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>

[kudu-CR] clang-tidy fixes from LLVm 6

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9899 )

Change subject: clang-tidy fixes from LLVm 6
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 03 Apr 2018 03:39:58 +0000
Gerrit-HasComments: No

[kudu-CR] Various fixes for clang-tidy errors

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9899

to look at the new patch set (#4).

Change subject: Various fixes for clang-tidy errors
......................................................................

Various fixes for clang-tidy errors

This updates the clang-tidy config to enable a few new checks and rename a few
old ones which were renamed in clang. I also ran through a bunch of checks
and fixed them using the following command:

find ../../src/kudu/ -name \*.cc | \
  grep -v -- -test | \
  grep -v gutil | \
  xargs -P80 -I{} -n1 ../../thirdparty/clang-toolchain/bin/clang-tidy \
  -checks=-readability*,-llvm-include-order,-modernize-use-nullptr,-google-readability-*,-misc-unused-*,-performance-inefficient-vector-operation \
  -p . --extra-arg=-DCLANG_TIDY -quiet {}

The above generated mostly straight-forward issues.

Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
---
M src/kudu/.clang-tidy
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/index-test.cc
M src/kudu/client/client.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/codegen/row_projector.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/peer_manager.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/experiments/merge-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/gutil/port.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/sys_catalog.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/periodic.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/remote_method.cc
M src/kudu/rpc/remote_method.h
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/transfer.cc
M src/kudu/security/cert.cc
M src/kudu/tablet/compaction_policy.cc
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_bootstrap.h
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_copy_source_session.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/easy_json.cc
M src/kudu/util/easy_json.h
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hexdump.cc
M src/kudu/util/inline_slice.h
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
M src/kudu/util/metrics.cc
M src/kudu/util/net/dns_resolver.cc
M src/kudu/util/net/socket.cc
M src/kudu/util/net/socket.h
M src/kudu/util/pb_util.cc
M src/kudu/util/status-test.cc
95 files changed, 345 insertions(+), 315 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9899/4
-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] Various fixes for clang-tidy errors

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9899 )

Change subject: Various fixes for clang-tidy errors
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Apr 2018 21:03:40 +0000
Gerrit-HasComments: No

[kudu-CR] Various fixes for clang-tidy errors

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9899 )

Change subject: Various fixes for clang-tidy errors
......................................................................

Various fixes for clang-tidy errors

This updates the clang-tidy config to enable a few new checks and rename a few
old ones which were renamed in clang. I also ran through a bunch of checks
and fixed them using the following command:

find ../../src/kudu/ -name \*.cc | \
  grep -v -- -test | \
  grep -v gutil | \
  xargs -P80 -I{} -n1 ../../thirdparty/clang-toolchain/bin/clang-tidy \
  -checks=-readability*,-llvm-include-order,-modernize-use-nullptr,-google-readability-*,-misc-unused-*,-performance-inefficient-vector-operation \
  -p . --extra-arg=-DCLANG_TIDY -quiet {}

The above generated mostly straight-forward issues.

Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Reviewed-on: http://gerrit.cloudera.org:8080/9899
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/.clang-tidy
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/index-test.cc
M src/kudu/client/client.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/codegen/row_projector.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/peer_manager.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/experiments/merge-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/gutil/port.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/sys_catalog.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/periodic.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/remote_method.cc
M src/kudu/rpc/remote_method.h
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/transfer.cc
M src/kudu/security/cert.cc
M src/kudu/tablet/compaction_policy.cc
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_bootstrap.h
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_copy_source_session.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/easy_json.cc
M src/kudu/util/easy_json.h
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hexdump.cc
M src/kudu/util/inline_slice.h
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
M src/kudu/util/metrics.cc
M src/kudu/util/net/dns_resolver.cc
M src/kudu/util/net/socket.cc
M src/kudu/util/net/socket.h
M src/kudu/util/pb_util.cc
M src/kudu/util/status-test.cc
95 files changed, 345 insertions(+), 315 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Various fixes for clang-tidy errors

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9899 )

Change subject: Various fixes for clang-tidy errors
......................................................................


Patch Set 3:

(12 comments)

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/cfile/index-test.cc
File src/kudu/cfile/index-test.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/cfile/index-test.cc@43
PS2, Line 43:                             const std::string &search_key,
> Nit: const std::string&
yea, the latter -- consistency within a declaration seemed better than following the new guide


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/client/meta_cache.h
File src/kudu/client/meta_cache.h:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/client/meta_cache.h@141
PS2, Line 141:                         RemoteTablet* tablet);
> warning: parameter 'tablet' is const-qualified in the function declaration;
Done


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/client/schema.h
File src/kudu/client/schema.h:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/client/schema.h@258
PS2, Line 258:       const void* default_value = NULL, //NOLINT(modernize-use-nullptr)
> warning: use nullptr [modernize-use-nullptr]
Done


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition.cc@119
PS2, Line 119:     for (const auto& identifier : identifiers) {
> Could use const auto here too.
Done


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition_pruner.cc
File src/kudu/common/partition_pruner.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition_pruner.cc@163
PS2, Line 163:   for (const auto& column : range_columns) {
> Could use const auto
Done


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/schema.h
File src/kudu/common/schema.h:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/schema.h@70
PS2, Line 70:   explicit ColumnId(int32_t t) : t_(t) {}
> warning: invalid case style for parameter 't_' [readability-identifier-nami
Done


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/schema.h@72
PS2, Line 72:   ColumnId(const ColumnId& o) = default;
> warning: invalid case style for parameter 't_' [readability-identifier-nami
Done


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/schema.h@76
PS2, Line 76:   operator const int32_t() const { return t_; } // NOLINT
> warning: 'operator const int' must be marked explicit to avoid unintentiona
Done


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/rowset_info.cc
File src/kudu/tablet/rowset_info.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/rowset_info.cc@207
PS2, Line 207:     if (rs->IsAvailableForCompaction()) {
> Could use const auto
Done


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/transactions/transaction_tracker.cc
File src/kudu/tablet/transactions/transaction_tracker.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/transactions/transaction_tracker.cc@230
PS2, Line 230:       for (const auto& driver : txns) {
> Const auto?
Done


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/util/net/dns_resolver.cc
File src/kudu/util/net/dns_resolver.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/util/net/dns_resolver.cc@50
PS2, Line 50: void DoResolution(const HostPort &hostport, vector<Sockaddr>* addresses,
> warning: 'DoResolution' is a static definition in anonymous namespace; stat
Done


http://gerrit.cloudera.org:8080/#/c/9899/3/src/kudu/util/net/dns_resolver.cc
File src/kudu/util/net/dns_resolver.cc:

http://gerrit.cloudera.org:8080/#/c/9899/3/src/kudu/util/net/dns_resolver.cc@51
PS3, Line 51:                          const StatusCallback& cb) {
> Nit: indentation
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 23 Apr 2018 20:00:21 +0000
Gerrit-HasComments: Yes

[kudu-CR] Various fixes for clang-tidy errors

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9899

to look at the new patch set (#2).

Change subject: Various fixes for clang-tidy errors
......................................................................

Various fixes for clang-tidy errors

This updates the clang-tidy config to enable a few new checks and rename a few
old ones which were renamed in clang. I also ran through a bunch of checks
and fixed them using the following command:

find ../../src/kudu/ -name \*.cc | \
  grep -v -- -test | \
  grep -v gutil | \
  xargs -P80 -I{} -n1 ../../thirdparty/clang-toolchain/bin/clang-tidy \
  -checks=-readability*,-llvm-include-order,-modernize-use-nullptr,-google-readability-*,-misc-unused-*,-performance-inefficient-vector-operation \
  -p . --extra-arg=-DCLANG_TIDY -quiet {}

The above generated mostly straight-forward issues.

Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
---
M src/kudu/.clang-tidy
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/index-test.cc
M src/kudu/client/client.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/codegen/row_projector.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/peer_manager.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/experiments/merge-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/gutil/port.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/sys_catalog.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/periodic.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/remote_method.cc
M src/kudu/rpc/remote_method.h
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/transfer.cc
M src/kudu/security/cert.cc
M src/kudu/tablet/compaction_policy.cc
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_bootstrap.h
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_copy_source_session.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/easy_json.cc
M src/kudu/util/easy_json.h
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hexdump.cc
M src/kudu/util/inline_slice.h
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
M src/kudu/util/metrics.cc
M src/kudu/util/net/dns_resolver.cc
M src/kudu/util/net/socket.cc
M src/kudu/util/net/socket.h
M src/kudu/util/pb_util.cc
M src/kudu/util/status-test.cc
96 files changed, 310 insertions(+), 279 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9899/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Various fixes for clang-tidy errors

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9899

to look at the new patch set (#3).

Change subject: Various fixes for clang-tidy errors
......................................................................

Various fixes for clang-tidy errors

This updates the clang-tidy config to enable a few new checks and rename a few
old ones which were renamed in clang. I also ran through a bunch of checks
and fixed them using the following command:

find ../../src/kudu/ -name \*.cc | \
  grep -v -- -test | \
  grep -v gutil | \
  xargs -P80 -I{} -n1 ../../thirdparty/clang-toolchain/bin/clang-tidy \
  -checks=-readability*,-llvm-include-order,-modernize-use-nullptr,-google-readability-*,-misc-unused-*,-performance-inefficient-vector-operation \
  -p . --extra-arg=-DCLANG_TIDY -quiet {}

The above generated mostly straight-forward issues.

Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
---
M src/kudu/.clang-tidy
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/index-test.cc
M src/kudu/client/client.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/codegen/row_projector.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/peer_manager.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/experiments/merge-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/gutil/port.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/sys_catalog.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/periodic.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/remote_method.cc
M src/kudu/rpc/remote_method.h
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/transfer.cc
M src/kudu/security/cert.cc
M src/kudu/tablet/compaction_policy.cc
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_bootstrap.h
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/tool_action.cc
M src/kudu/tools/tool_action_cluster.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/tserver/tablet_copy_source_session.cc
M src/kudu/tserver/tablet_copy_source_session.h
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/easy_json.cc
M src/kudu/util/easy_json.h
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hexdump.cc
M src/kudu/util/inline_slice.h
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
M src/kudu/util/metrics.cc
M src/kudu/util/net/dns_resolver.cc
M src/kudu/util/net/socket.cc
M src/kudu/util/net/socket.h
M src/kudu/util/pb_util.cc
M src/kudu/util/status-test.cc
95 files changed, 345 insertions(+), 315 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/9899/3
-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot

[kudu-CR] Various fixes for clang-tidy errors

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9899 )

Change subject: Various fixes for clang-tidy errors
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/cfile/index-test.cc
File src/kudu/cfile/index-test.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/cfile/index-test.cc@43
PS2, Line 43:                             const std::string &search_key,
Nit: const std::string&

Or were you trying to be consistent with the style of the other args?


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition.cc@119
PS2, Line 119:     for (const PartitionSchemaPB_ColumnIdentifierPB& identifier : identifiers) {
Could use const auto here too.


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition_pruner.cc
File src/kudu/common/partition_pruner.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/common/partition_pruner.cc@163
PS2, Line 163:   for (const ColumnId& column : range_columns) {
Could use const auto


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/rowset_info.cc
File src/kudu/tablet/rowset_info.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/rowset_info.cc@207
PS2, Line 207:   for (const shared_ptr<RowSet>& rs : tree.all_rowsets()) {
Could use const auto


http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/transactions/transaction_tracker.cc
File src/kudu/tablet/transactions/transaction_tracker.cc:

http://gerrit.cloudera.org:8080/#/c/9899/2/src/kudu/tablet/transactions/transaction_tracker.cc@230
PS2, Line 230:       for (const scoped_refptr<TransactionDriver>& driver : txns) {
Const auto?



-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 18 Apr 2018 19:52:31 +0000
Gerrit-HasComments: Yes

[kudu-CR] Various fixes for clang-tidy errors

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9899 )

Change subject: Various fixes for clang-tidy errors
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9899/3/src/kudu/util/net/dns_resolver.cc
File src/kudu/util/net/dns_resolver.cc:

http://gerrit.cloudera.org:8080/#/c/9899/3/src/kudu/util/net/dns_resolver.cc@51
PS3, Line 51:                          const StatusCallback& cb) {
Nit: indentation



-- 
To view, visit http://gerrit.cloudera.org:8080/9899
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69e2e1be80ec68537df101a4f508b4f1cf6e1342
Gerrit-Change-Number: 9899
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Mon, 23 Apr 2018 19:50:48 +0000
Gerrit-HasComments: Yes