You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2009/02/02 04:30:00 UTC

[jira] Created: (HIVE-264) TBinarySortable Protocol should support null characters

TBinarySortable Protocol should support null characters
-------------------------------------------------------

                 Key: HIVE-264
                 URL: https://issues.apache.org/jira/browse/HIVE-264
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Serializers/Deserializers
    Affects Versions: 0.2.0
            Reporter: Zheng Shao
            Assignee: Zheng Shao


Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
We should support that.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment: string.txt

string.txt that contains ^@ and ^A

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670558#action_12670558 ] 

Prasad Chakka commented on HIVE-264:
------------------------------------

+1

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, HIVE-264.2.patch, HIVE-264.3.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment: HIVE-264.3.patch

Fixed the assert bug as Prasad pointed out.


> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, HIVE-264.2.patch, HIVE-264.3.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment:     (was: HIVE-264.1.patch)

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment: HIVE-264.5.patch

Increased test timeout to 1800 seconds because TestCliDriver is taking longer and longer time.

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, HIVE-264.2.patch, HIVE-264.3.patch, HIVE-264.5.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment: HIVE-264.1.patch

Replaced special characters in the query output with normal characters.

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670547#action_12670547 ] 

Prasad Chakka commented on HIVE-264:
------------------------------------

the line below

 assert(bin[0] == 1 || bin[1] == 2);


should be


 assert(bin[0] == 1 || bin[0] == 2);

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, HIVE-264.2.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment: HIVE-264.1.patch

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment: HIVE-264.1.patch

including a testcase with both ^@ and ^A characters.

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment: HIVE-264.2.patch

Reverted logging change.

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, HIVE-264.2.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670250#action_12670250 ] 

Prasad Chakka commented on HIVE-264:
------------------------------------

logging is set to debug

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment:     (was: HIVE-264.1.patch)

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment:     (was: HIVE-264.5.patch)

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, HIVE-264.2.patch, HIVE-264.3.patch, HIVE-264.5.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao resolved HIVE-264.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 0.3.0
                   0.2.0
     Release Note: HIVE-264. TBinarySortable Protocol supports null characters. (zshao)
     Hadoop Flags: [Reviewed]

Committed revision 741341 for branch 0.2.
Committed revision 741339 for trunk.

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.2.0, 0.3.0
>
>         Attachments: HIVE-264.1.patch, HIVE-264.2.patch, HIVE-264.3.patch, HIVE-264.5.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-264:
--------------------------------

    Fix Version/s:     (was: 0.6.0)

> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.6.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.3.0
>
>         Attachments: HIVE-264.1.patch, HIVE-264.2.patch, HIVE-264.3.patch, HIVE-264.5.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669503#action_12669503 ] 

Zheng Shao commented on HIVE-264:
---------------------------------

A simple way to do that is to escape "\000" with "\001" "\001", and escape "\001" with "\001" "\002",


> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-264) TBinarySortable Protocol should support null characters

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-264:
----------------------------

    Attachment: HIVE-264.5.patch

Added "-a" to "diff" command to always compare file in text mode.


> TBinarySortable Protocol should support null characters
> -------------------------------------------------------
>
>                 Key: HIVE-264
>                 URL: https://issues.apache.org/jira/browse/HIVE-264
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.2.0
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>         Attachments: HIVE-264.1.patch, HIVE-264.2.patch, HIVE-264.3.patch, HIVE-264.5.patch, string.txt
>
>
> Currently TBinarySortable Protocol does not support serializing null "\0" characters which confused a lot of users.
> We should support that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.