You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "mailtoboggavarapu-coder (via GitHub)" <gi...@apache.org> on 2026/04/04 18:22:11 UTC

[PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

mailtoboggavarapu-coder opened a new pull request, #18467:
URL: https://github.com/apache/hudi/pull/18467

   ### Describe the issue this Pull Request
   ### Problem
   
   `SqlFileBasedSource.fetchNextBatch` creates a `Scanner` inside a plain `try` block, so it is never closed if an exception occurs or even on the normal path — the stream backing the `Scanner` is left open.
   
   ```java
   // Before (leaks Scanner)
   try {
     final Scanner scanner = new Scanner(fs.open(new Path(sourceSqlFile)));
     scanner.useDelimiter(";");
     ...
   }
   ```
   
   ### Fix
   
   Wrap the `Scanner` in a try-with-resources statement so it is automatically closed when the block exits (normally or exceptionally).
   
   ```java
   // After (Scanner closed automatically)
   try (final Scanner scanner = new Scanner(fs.open(new Path(sourceSqlFile)))) {
     scanner.useDelimiter(";");
     ...
   }
   ```<!-- Either describe the issue inline here with motivation behind the changes 
        (or) link to an issue by including `Closes #<issue-number>` for context. 
        If this PR includes changes to the storage format, public APIs,
        or has breaking changes, use `!` (e.g., feat!: ...) -->
   
   ### Summary and Changelog
   
   <!-- Short, plain-English summary of what users gain or what changed in behavior.
        Followed by a detailed log of all the changes. Highlight if any code was copied. -->
   
   ### Impact
   
   <!-- Describe any public API or user-facing feature change or any performance impact. -->
   
   ### Risk Level
   
   <!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
        If medium or high, explain what verification was done to mitigate the risks. -->
   
   ### Documentation Update
   
   <!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
   
   - The config description must be updated if new configs are added or the default value of the configs are changed.
   - Any new feature or user-facing change requires updating the Hudi website. Please follow the 
     [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192843056

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   + Coverage     68.53%   68.74%   +0.20%     
   - Complexity    28037    28057      +20     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   + Hits          92356    92437      +81     
   + Misses        35112    34734     -378     
   - Partials       7284     7288       +4     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.76% <0.00%> (-0.02%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.61% <0.00%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "mailtoboggavarapu-coder (via GitHub)" <gi...@apache.org>.
mailtoboggavarapu-coder commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256202905

   Pinging for committer approval. This PR fixes a genuine `Scanner` resource leak in `SqlFileBasedSource.fetchNextBatch` — a `Scanner` used to read a SQL file is never closed, leaking a file handle on every batch fetch. The fix wraps it in a try-with-resources block so it is automatically closed. @yihua has already reviewed and LGTM'd this. Would appreciate a review and merge from a committer with write access to `apache/hudi` (@vinothchandrasekar / @alexeykudinkin / @danny0405 / @nsivabalan).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256299791

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 44.87%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4f83437`](https://app.codecov.io/gh/apache/hudi/commit/4f834374e640d9e84e2b2835818ff56a35b6507c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     45.68%   44.87%   -0.81%     
   + Complexity    15338     8491    -6847     
   ============================================
     Files          1975     1196     -779     
     Lines        109633    62041   -47592     
     Branches      13696     6683    -7013     
   ============================================
   - Hits          50085    27841   -22244     
   + Misses        54259    31161   -23098     
   + Partials       5289     3039    -2250     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   [see 1324 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256481286

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 53.96%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|12|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   53.96%   -12.54%     
   + Complexity    22910    12290    -10620     
   =============================================
     Files          2004     1425      -579     
     Lines        112236    71029    -41207     
     Branches      14250     8016     -6234     
   =============================================
   - Hits          74645    38334    -36311     
   + Misses        31087    29266     -1821     
   + Partials       6504     3429     -3075     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   [see 1291 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256544226

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.85%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 10 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|7|
   >|spark-java-tests|12|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     66.50%   60.85%   -5.66%     
   + Complexity    22910    20677    -2233     
   ============================================
     Files          2004     2004              
     Lines        112236   112236              
     Branches      14250    14250              
   ============================================
   - Hits          74645    68297    -6348     
   - Misses        31087    37161    +6074     
   - Partials       6504     6778     +274     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.49%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.18% <0.00%> (-0.34%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [520 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256555621

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.27%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     66.50%   65.27%   -1.24%     
   + Complexity    22910    22471     -439     
   ============================================
     Files          2004     2004              
     Lines        112236   112236              
     Branches      14250    14250              
   ============================================
   - Hits          74645    73260    -1385     
   - Misses        31087    32381    +1294     
   - Partials       6504     6595      +91     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <0.00%> (-3.72%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <0.00%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [179 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192639840

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 54.02%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 27 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     68.53%   54.02%   -14.52%     
   + Complexity    28037    12259    -15778     
   =============================================
     Files          2444     1424     -1020     
     Lines        134752    70739    -64013     
     Branches      16292     7955     -8337     
   =============================================
   - Hits          92356    38214    -54142     
   + Misses        35112    29107     -6005     
   + Partials       7284     3418     -3866     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   [see 1794 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192724368

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.63%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   67.63%   -0.90%     
   + Complexity    28037    27580     -457     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    90946    -1410     
   - Misses        35112    36215    +1103     
   - Partials       7284     7298      +14     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-3.83%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <0.00%> (-0.38%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [205 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256490382

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074",
       "triggerID" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13285",
       "triggerID" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4721250a5404ec2b8cc782eb3fbadf765879ff5b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13292",
       "triggerID" : "4721250a5404ec2b8cc782eb3fbadf765879ff5b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f45a0310151290917599f5ae0e774c561cc5372 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074) 
   * 4f834374e640d9e84e2b2835818ff56a35b6507c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13285) 
   * 4721250a5404ec2b8cc782eb3fbadf765879ff5b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13292) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256529708

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.67%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 11 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|6|
   >|spark-java-tests|12|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     66.50%   60.67%   -5.83%     
   + Complexity    22910    20602    -2308     
   ============================================
     Files          2004     2004              
     Lines        112236   112236              
     Branches      14250    14250              
   ============================================
   - Hits          74645    68102    -6543     
   - Misses        31087    37377    +6290     
   - Partials       6504     6757     +253     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.49%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.55%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [542 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4257112266

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074",
       "triggerID" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13285",
       "triggerID" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4721250a5404ec2b8cc782eb3fbadf765879ff5b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13292",
       "triggerID" : "4721250a5404ec2b8cc782eb3fbadf765879ff5b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4721250a5404ec2b8cc782eb3fbadf765879ff5b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13292) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "mailtoboggavarapu-coder (via GitHub)" <gi...@apache.org>.
mailtoboggavarapu-coder commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256382907

   ### CI Build Failures — Master Branch Issue (not this PR)
   
   The `Java CI` build failures on this PR are **not caused by our code changes**. Investigation shows this is a master branch build issue introduced by commit [d3e0201](https://github.com/apache/hudi/commit/d3e020132a) ("fix(common): FutureUtils:allOf should always throw root cause exception", merged 2026-04-15T22:30Z).
   
   **Evidence:**
   - The master branch CI run for d3e0201 ([run 24481746190](https://github.com/apache/hudi/actions/runs/24481746190)) shows the same "Build Project" step failures in `test-common-and-other-modules` and `test-spark-java-tests-part2` jobs
   - Our code changes touch completely unrelated files (`DFSPropertiesConfiguration.java` / `HiveIncrementalPuller.java` / `FileSystemBasedLockProvider.java` / `SqlFileBasedSource.java`) — none of which interact with `FutureUtils`
   - The last successful PR CI run before d3e0201 (nsivabalan's run at 21:53 UTC same day) passed all 53/53 jobs with identical matrix configuration
   - Build failures occur in ~83–111 seconds (a full Maven build normally takes 340s+), consistent with an early Maven resolution/plugin failure rather than a compilation error in our code
   
   The CI situation is being tracked. Once the master build stabilises, a re-run of CI on this PR should pass.
   
   cc @vinothchandrasekar @alexeykudinkin @danny0405 @nsivabalan — would appreciate a re-run once the master build issue is resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192531741

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 44.90%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 28 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-client-hadoop-common|1|0|
   >|spark-scala-tests|10|0|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     68.53%   44.90%   -23.64%     
   + Complexity    28037     8471    -19566     
   =============================================
     Files          2444     1195     -1249     
     Lines        134752    61829    -72923     
     Branches      16292     6641     -9651     
   =============================================
   - Hits          92356    27765    -64591     
   + Misses        35112    31033     -4079     
   + Partials       7284     3031     -4253     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   [see 2048 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192697843

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.43%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 15 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   61.43%   -7.11%     
   + Complexity    28037    24974    -3063     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    82607    -9749     
   - Misses        35112    44921    +9809     
   + Partials       7284     6931     -353     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.43% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.99%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [554 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192834848

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   + Coverage     68.53%   68.74%   +0.20%     
   - Complexity    28037    28057      +20     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   + Hits          92356    92437      +81     
   + Misses        35112    34734     -378     
   - Partials       7284     7288       +4     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.73% <0.00%> (-0.05%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.61% <0.00%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256868243

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.86%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   + Coverage     66.50%   68.86%   +2.35%     
   - Complexity    22910    28238    +5328     
   ============================================
     Files          2004     2460     +456     
     Lines        112236   135260   +23024     
     Branches      14250    16392    +2142     
   ============================================
   + Hits          74645    93141   +18496     
   - Misses        31087    34748    +3661     
   - Partials       6504     7371     +867     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <100.00%> (?)` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <0.00%> (+0.06%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <0.00%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (+89.47%)` | :arrow_up: |
   
   ... and [800 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256498858

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.21%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|12|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   45.21%   -21.30%     
   + Complexity    22910    15553     -7357     
   =============================================
     Files          2004     2004               
     Lines        112236   112236               
     Branches      14250    14250               
   =============================================
   - Hits          74645    50746    -23899     
   - Misses        31087    56039    +24952     
   + Partials       6504     5451     -1053     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <0.00%> (-12.94%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [959 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #18467:
URL: https://github.com/apache/hudi/pull/18467


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256414870

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 44.87%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|0|
   >|spark-client-hadoop-common|1|0|
   >|spark-java-tests|12|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   44.87%   -21.63%     
   + Complexity    22910     8493    -14417     
   =============================================
     Files          2004     1196      -808     
     Lines        112236    62041    -50195     
     Branches      14250     6683     -7567     
   =============================================
   - Hits          74645    27843    -46802     
   - Misses        31087    31160       +73     
   + Partials       6504     3038     -3466     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   [see 1563 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256493617

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.67%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|12|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   45.67%   -20.83%     
   + Complexity    22910    15338     -7572     
   =============================================
     Files          2004     1975       -29     
     Lines        112236   109628     -2608     
     Branches      14250    13690      -560     
   =============================================
   - Hits          74645    50077    -24568     
   - Misses        31087    54263    +23176     
   + Partials       6504     5288     -1216     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <0.00%> (-12.82%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [978 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256492840

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.67%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 20 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|12|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   45.67%   -20.83%     
   + Complexity    22910    15338     -7572     
   =============================================
     Files          2004     1975       -29     
     Lines        112236   109628     -2608     
     Branches      14250    13690      -560     
   =============================================
   - Hits          74645    50077    -24568     
   - Misses        31087    54263    +23176     
   + Partials       6504     5288     -1216     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.70% <0.00%> (-12.82%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [978 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256547768

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 60.99%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 9 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|8|
   >|spark-java-tests|12|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     66.50%   60.99%   -5.52%     
   + Complexity    22910    20744    -2166     
   ============================================
     Files          2004     2004              
     Lines        112236   112236              
     Branches      14250    14250              
   ============================================
   - Hits          74645    68457    -6188     
   - Misses        31087    36954    +5867     
   - Partials       6504     6825     +321     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.49%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <0.00%> (-0.16%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [506 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256563816

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.50%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18467   +/-   ##
   =========================================
     Coverage     66.50%   66.50%           
     Complexity    22910    22910           
   =========================================
     Files          2004     2004           
     Lines        112236   112236           
     Branches      14250    14250           
   =========================================
   + Hits          74645    74647    +2     
   + Misses        31087    31085    -2     
     Partials       6504     6504           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <0.00%> (-0.01%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <0.00%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256256575

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074",
       "triggerID" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f45a0310151290917599f5ae0e774c561cc5372 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074) 
   * 4f834374e640d9e84e2b2835818ff56a35b6507c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192680868

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.20%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     68.53%   48.20%   -20.33%     
   + Complexity    28037    16440    -11597     
   =============================================
     Files          2444     1998      -446     
     Lines        134752   111560    -23192     
     Branches      16292    14121     -2171     
   =============================================
   - Hits          92356    53781    -38575     
   - Misses        35112    52164    +17052     
   + Partials       7284     5615     -1669     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.43% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.99%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   
   ... and [1512 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192679098

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.20%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     68.53%   48.20%   -20.33%     
   + Complexity    28037    16440    -11597     
   =============================================
     Files          2444     1998      -446     
     Lines        134752   111560    -23192     
     Branches      16292    14121     -2171     
   =============================================
   - Hits          92356    53781    -38575     
   - Misses        35112    52164    +17052     
   + Partials       7284     5615     -1669     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.43% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.99%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   
   ... and [1512 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192660583

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.30%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 22 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     68.53%   45.30%   -23.24%     
   + Complexity    28037    15501    -12536     
   =============================================
     Files          2444     1998      -446     
     Lines        134752   111560    -23192     
     Branches      16292    14121     -2171     
   =============================================
   - Hits          92356    50541    -41815     
   - Misses        35112    55603    +20491     
   + Partials       7284     5416     -1868     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.99%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   
   ... and [1562 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192844037

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   + Coverage     68.53%   68.74%   +0.21%     
   - Complexity    28037    28058      +21     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   + Hits          92356    92440      +84     
   + Misses        35112    34733     -379     
   - Partials       7284     7286       +2     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <0.00%> (-0.02%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.61% <0.00%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4187646045

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074",
       "triggerID" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f45a0310151290917599f5ae0e774c561cc5372 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256555159

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 65.27%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     66.50%   65.27%   -1.24%     
   + Complexity    22910    22471     -439     
   ============================================
     Files          2004     2004              
     Lines        112236   112236              
     Branches      14250    14250              
   ============================================
   - Hits          74645    73260    -1385     
   - Misses        31087    32381    +1294     
   - Partials       6504     6595      +91     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <0.00%> (-3.72%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <0.00%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [179 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192649006

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.35%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     68.53%   46.35%   -22.19%     
   + Complexity    28037    15128    -12909     
   =============================================
     Files          2444     1952      -492     
     Lines        134752   106593    -28159     
     Branches      16292    13062     -3230     
   =============================================
   - Hits          92356    49413    -42943     
   - Misses        35112    52068    +16956     
   + Partials       7284     5112     -2172     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.06% <0.00%> (-12.56%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   
   ... and [1588 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192677371

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.20%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|4|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     68.53%   48.20%   -20.33%     
   + Complexity    28037    16440    -11597     
   =============================================
     Files          2444     1998      -446     
     Lines        134752   111560    -23192     
     Branches      16292    14121     -2171     
   =============================================
   - Hits          92356    53781    -38575     
   - Misses        35112    52164    +17052     
   + Partials       7284     5615     -1669     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.43% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.99%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   
   ... and [1512 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192657702

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.85%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 23 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|4|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     68.53%   45.85%   -22.69%     
   + Complexity    28037    15340    -12697     
   =============================================
     Files          2444     1981      -463     
     Lines        134752   109201    -25551     
     Branches      16292    13618     -2674     
   =============================================
   - Hits          92356    50074    -42282     
   - Misses        35112    53853    +18741     
   + Partials       7284     5274     -2010     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <0.00%> (-12.71%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   
   ... and [1573 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256507228

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.09%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 14 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|12|4|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   48.09%   -18.42%     
   + Complexity    22910    16497     -6413     
   =============================================
     Files          2004     2004               
     Lines        112236   112236               
     Branches      14250    14250               
   =============================================
   - Hits          74645    53977    -20668     
   - Misses        31087    52613    +21526     
   + Partials       6504     5646      -858     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.49%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <0.00%> (-12.94%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [903 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256498462

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 45.21%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 18 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|12|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   45.21%   -21.30%     
   + Complexity    22910    15553     -7357     
   =============================================
     Files          2004     2004               
     Lines        112236   112236               
     Branches      14250    14250               
   =============================================
   - Hits          74645    50746    -23899     
   - Misses        31087    56039    +24952     
   + Partials       6504     5451     -1053     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <0.00%> (-12.94%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [959 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256512856

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 54.40%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 13 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|12|4|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   54.40%   -12.10%     
   + Complexity    22910    18456     -4454     
   =============================================
     Files          2004     2004               
     Lines        112236   112236               
     Branches      14250    14250               
   =============================================
   - Hits          74645    61065    -13580     
   - Misses        31087    44902    +13815     
   + Partials       6504     6269      -235     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.49%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <0.00%> (-12.94%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [715 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256519470

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 54.40%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 12 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|12|5|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   54.40%   -12.10%     
   + Complexity    22910    18456     -4454     
   =============================================
     Files          2004     2004               
     Lines        112236   112236               
     Branches      14250    14250               
   =============================================
   - Hits          74645    61065    -13580     
   - Misses        31087    44902    +13815     
   + Partials       6504     6269      -235     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.49%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <0.00%> (-12.94%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [715 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256560522

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.49%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     66.50%   66.49%   -0.01%     
     Complexity    22910    22910              
   ============================================
     Files          2004     2004              
     Lines        112236   112236              
     Branches      14250    14250              
   ============================================
   - Hits          74645    74635      -10     
   - Misses        31087    31096       +9     
   - Partials       6504     6505       +1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <0.00%> (-0.06%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <0.00%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192649815

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 46.35%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 24 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|3|
   >|spark-java-tests|15|0|
   >|common-and-other-modules|1|0|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     68.53%   46.35%   -22.19%     
   + Complexity    28037    15128    -12909     
   =============================================
     Files          2444     1952      -492     
     Lines        134752   106593    -28159     
     Branches      16292    13062     -3230     
   =============================================
   - Hits          92356    49413    -42943     
   - Misses        35112    52068    +16956     
   + Partials       7284     5112     -2172     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.06% <0.00%> (-12.56%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: |
   
   ... and [1588 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192701992

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 66.02%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   66.02%   -2.52%     
   + Complexity    28037    26836    -1201     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    88774    -3582     
   - Misses        35112    38300    +3188     
   - Partials       7284     7385     +101     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.43% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <0.00%> (-0.56%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [385 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4187542635

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074",
       "triggerID" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f45a0310151290917599f5ae0e774c561cc5372 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192765895

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.90%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   67.90%   -0.64%     
   + Complexity    28037    27713     -324     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    91302    -1054     
   - Misses        35112    35798     +686     
   - Partials       7284     7359      +75     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <0.00%> (-3.77%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.61% <0.00%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [166 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192730508

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.67%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   67.67%   -0.87%     
   + Complexity    28037    27580     -457     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    90992    -1364     
   - Misses        35112    36202    +1090     
   + Partials       7284     7265      -19     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-3.83%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.33%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [184 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192792308

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   + Coverage     68.53%   68.74%   +0.20%     
   - Complexity    28037    28056      +19     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   + Hits          92356    92434      +78     
   + Misses        35112    34737     -375     
   - Partials       7284     7288       +4     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <0.00%> (-0.09%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.61% <0.00%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256612483

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.51%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18467   +/-   ##
   =========================================
     Coverage     66.50%   66.51%           
   - Complexity    22910    22911    +1     
   =========================================
     Files          2004     2004           
     Lines        112236   112236           
     Branches      14250    14250           
   =========================================
   + Hits          74645    74651    +6     
   + Misses        31087    31082    -5     
   + Partials       6504     6503    -1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <0.00%> (+0.06%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <0.00%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256379260

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074",
       "triggerID" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13285",
       "triggerID" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4721250a5404ec2b8cc782eb3fbadf765879ff5b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4721250a5404ec2b8cc782eb3fbadf765879ff5b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f45a0310151290917599f5ae0e774c561cc5372 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074) 
   * 4f834374e640d9e84e2b2835818ff56a35b6507c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13285) 
   * 4721250a5404ec2b8cc782eb3fbadf765879ff5b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256613267

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.51%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18467   +/-   ##
   =========================================
     Coverage     66.50%   66.51%           
   - Complexity    22910    22911    +1     
   =========================================
     Files          2004     2004           
     Lines        112236   112236           
     Branches      14250    14250           
   =========================================
   + Hits          74645    74651    +6     
   + Misses        31087    31082    -5     
   + Partials       6504     6503    -1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.93% <0.00%> (+0.06%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <0.00%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256560980

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.49%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     66.50%   66.49%   -0.01%     
     Complexity    22910    22910              
   ============================================
     Files          2004     2004              
     Lines        112236   112236              
     Branches      14250    14250              
   ============================================
   - Hits          74645    74635      -10     
   - Misses        31087    31096       +9     
   - Partials       6504     6505       +1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.82% <0.00%> (-0.06%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <0.00%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192771961

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.96%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   67.96%   -0.58%     
   + Complexity    28037    27749     -288     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    91379     -977     
   - Misses        35112    35730     +618     
   - Partials       7284     7350      +66     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <0.00%> (-3.64%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.61% <0.00%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [150 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192775060

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   + Coverage     68.53%   68.74%   +0.20%     
   - Complexity    28037    28055      +18     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   + Hits          92356    92428      +72     
   + Misses        35112    34740     -372     
   - Partials       7284     7291       +7     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <0.00%> (-0.13%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.61% <0.00%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [29 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192780846

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 68.74%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   + Coverage     68.53%   68.74%   +0.20%     
   - Complexity    28037    28055      +18     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   + Hits          92356    92429      +73     
   + Misses        35112    34739     -373     
   - Partials       7284     7291       +7     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <0.00%> (-0.13%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.61% <0.00%> (-0.02%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192683174

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 58.91%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   58.91%   -9.62%     
   + Complexity    28037    24009    -4028     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    79223   -13133     
   - Misses        35112    48461   +13349     
   + Partials       7284     6775     -509     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.43% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.99%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [669 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192747640

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.80%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   67.80%   -0.74%     
   + Complexity    28037    27651     -386     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    91170    -1186     
   - Misses        35112    35975     +863     
   - Partials       7284     7314      +30     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <0.00%> (-3.77%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.46% <0.00%> (-0.17%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [170 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4257010631

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074",
       "triggerID" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13285",
       "triggerID" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4721250a5404ec2b8cc782eb3fbadf765879ff5b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13292",
       "triggerID" : "4721250a5404ec2b8cc782eb3fbadf765879ff5b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4f834374e640d9e84e2b2835818ff56a35b6507c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13285) 
   * 4721250a5404ec2b8cc782eb3fbadf765879ff5b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13292) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256506802

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.09%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 14 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|12|4|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   48.09%   -18.42%     
   + Complexity    22910    16497     -6413     
   =============================================
     Files          2004     2004               
     Lines        112236   112236               
     Branches      14250    14250               
   =============================================
   - Hits          74645    53977    -20668     
   - Misses        31087    52613    +21526     
   + Partials       6504     5646      -858     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.49%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <0.00%> (-12.94%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [903 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256506365

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 48.09%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (d3e0201) and HEAD (4721250). Click for more details.
   > 
   > <details><summary>HEAD has 14 uploads less than BASE</summary>
   >
   >| Flag | BASE (d3e0201) | HEAD (4721250) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|12|4|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #18467       +/-   ##
   =============================================
   - Coverage     66.50%   48.09%   -18.42%     
   + Complexity    22910    16497     -6413     
   =============================================
     Files          2004     2004               
     Lines        112236   112236               
     Branches      14250    14250               
   =============================================
   - Hits          74645    53977    -20668     
   - Misses        31087    52613    +21526     
   + Partials       6504     5646      -858     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.49%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <0.00%> (-12.94%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [903 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256272057

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074",
       "triggerID" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13285",
       "triggerID" : "4f834374e640d9e84e2b2835818ff56a35b6507c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f45a0310151290917599f5ae0e774c561cc5372 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13074) 
   * 4f834374e640d9e84e2b2835818ff56a35b6507c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13285) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4256608280

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 66.51%. Comparing base ([`d3e0201`](https://app.codecov.io/gh/apache/hudi/commit/d3e020132a9151a34b54534c717892c43ebb0eac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4721250`](https://app.codecov.io/gh/apache/hudi/commit/4721250a5404ec2b8cc782eb3fbadf765879ff5b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18467   +/-   ##
   =========================================
     Coverage     66.50%   66.51%           
   - Complexity    22910    22911    +1     
   =========================================
     Files          2004     2004           
     Lines        112236   112236           
     Branches      14250    14250           
   =========================================
   + Hits          74645    74651    +6     
   + Misses        31087    31082    -5     
   + Partials       6504     6503    -1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.87% <ø> (-0.01%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.45% <ø> (+<0.01%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.90% <0.00%> (+0.02%)` | :arrow_up: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <0.00%> (-0.01%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.23% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192737365

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.70%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   67.70%   -0.84%     
   + Complexity    28037    27587     -450     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    91030    -1326     
   - Misses        35112    36162    +1050     
   + Partials       7284     7267      -17     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.01% <0.00%> (-3.77%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <0.00%> (-0.33%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [177 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192718850

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 67.52%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   67.52%   -1.02%     
   + Complexity    28037    27513     -524     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    90787    -1569     
   - Misses        35112    36421    +1309     
   + Partials       7284     7251      -33     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-3.83%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.06% <0.00%> (-0.56%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.34% <0.00%> (-0.03%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [216 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192688000

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 58.91%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   58.91%   -9.62%     
   + Complexity    28037    24009    -4028     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    79223   -13133     
   - Misses        35112    48461   +13349     
   + Partials       7284     6775     -509     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.43% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.99%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [669 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4192686527

   ## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 58.91%. Comparing base ([`76b4fa4`](https://app.codecov.io/gh/apache/hudi/commit/76b4fa404c724219f657cd64b788253bb31f23a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f45a03`](https://app.codecov.io/gh/apache/hudi/commit/8f45a0310151290917599f5ae0e774c561cc5372?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 5 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (76b4fa4) and HEAD (8f45a03). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (76b4fa4) | HEAD (8f45a03) |
   >|------|------|------|
   >|spark-scala-tests|10|5|
   >|spark-java-tests|15|5|
   >|utilities|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18467      +/-   ##
   ============================================
   - Coverage     68.53%   58.91%   -9.62%     
   + Complexity    28037    24009    -4028     
   ============================================
     Files          2444     2446       +2     
     Lines        134752   134459     -293     
     Branches      16292    16261      -31     
   ============================================
   - Hits          92356    79223   -13133     
   - Misses        35112    48461   +13349     
   + Partials       7284     6775     -509     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.51% <100.00%> (+0.15%)` | :arrow_up: |
   | [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.90% <ø> (-0.03%)` | :arrow_down: |
   | [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <ø> (+0.04%)` | :arrow_up: |
   | [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.43% <0.00%> (-16.36%)` | :arrow_down: |
   | [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <0.00%> (-12.99%)` | :arrow_down: |
   | [utilities](https://app.codecov.io/gh/apache/hudi/pull/18467/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...che/hudi/utilities/sources/SqlFileBasedSource.java](https://app.codecov.io/gh/apache/hudi/pull/18467?src=pr&el=tree&filepath=hudi-utilities%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futilities%2Fsources%2FSqlFileBasedSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvU3FsRmlsZUJhc2VkU291cmNlLmphdmE=) | `89.47% <100.00%> (ø)` | |
   
   ... and [669 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18467/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "mailtoboggavarapu-coder (via GitHub)" <gi...@apache.org>.
mailtoboggavarapu-coder commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4260360015

   Friendly reminder: CI is green on this PR. @vinothchandrasekar @alexeykudinkin @danny0405 @nsivabalan — would appreciate a review and approval when you get a chance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix Scanner resource leak in SqlFileBasedSource.fetchNextBatch [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18467:
URL: https://github.com/apache/hudi/pull/18467#issuecomment-4187538940

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8f45a0310151290917599f5ae0e774c561cc5372",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8f45a0310151290917599f5ae0e774c561cc5372 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org