You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/09 10:10:54 UTC
[GitHub] [doris] nextdreamblue opened a new pull request, #12513: [feature](http) refactor version info and add new http api for get version info
nextdreamblue opened a new pull request, #12513:
URL: https://github.com/apache/doris/pull/12513
# Proposed changes
Issue Number: close #xxx
## Problem summary
当前的doris的version信息就是一个可以自定义的字符串,对于有进行版本信息比较的场景不太友好。目前根据之前的命名规则,以及可能得其他信息,对version信息进行了拆分,分成了prefix、major、minor、patch、rc信息等几个单独的信息。
并且在fe和be上各增加了两个http接口,方便用户获取与版本相关的所有信息,用户可以根据这些信息去进行版本判断、分析、比较等行为。
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] No
2. Has unit tests been added:
- [ ] No
3. Has document been added or modified:
- [ ] Yes
4. Does it need to update dependencies:
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hf200012 commented on pull request #12513: [feature](http) refactor version info and add new http api for get version info
Posted by GitBox <gi...@apache.org>.
hf200012 commented on PR #12513:
URL: https://github.com/apache/doris/pull/12513#issuecomment-1241793682
It is recommended that the current version can be viewed in the start script of fe and be
For example.
sh bin/start_fe.sh --version
sh bin/start_be.sh --version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on a diff in pull request #12513: [feature](http) refactor version info and add new http api for get version info
Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on code in PR #12513:
URL: https://github.com/apache/doris/pull/12513#discussion_r973820465
##########
gensrc/script/gen_build_version.sh:
##########
@@ -27,7 +27,13 @@
set -eo pipefail
-build_version="trunk"
+build_version_prefix="doris"
Review Comment:
you can specify any version info you want in this script when you complie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on a diff in pull request #12513: [feature](http) refactor version info and add new http api for get version info
Posted by GitBox <gi...@apache.org>.
stalary commented on code in PR #12513:
URL: https://github.com/apache/doris/pull/12513#discussion_r970199496
##########
docs/en/docs/admin-manual/http-actions/be-version-info-action.md:
##########
@@ -0,0 +1,99 @@
+---
+{
+ "title": "Be Version Info Action",
+ "language": "zh-CN"
Review Comment:
```suggestion
"language": "en"
```
##########
gensrc/script/gen_build_version.sh:
##########
@@ -27,7 +27,13 @@
set -eo pipefail
-build_version="trunk"
+build_version_prefix="doris"
Review Comment:
Does it need to be manually modified when we publish the version?
##########
docs/en/docs/admin-manual/http-actions/fe/fe-version-info-action.md:
##########
@@ -0,0 +1,101 @@
+---
+{
+ "title": "Fe Version Info Action",
+ "language": "zh-CN"
Review Comment:
```suggestion
"language": "en"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #12513: [feature](http) refactor version info and add new http api for get version info
Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on PR #12513:
URL: https://github.com/apache/doris/pull/12513#issuecomment-1244947183
> It is recommended that the current version can be viewed in the start script of fe and be For example. sh bin/start_fe.sh --version sh bin/start_be.sh --version
if client want get version info, the script is not simple to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on a diff in pull request #12513: [feature](http) refactor version info and add new http api for get version info
Posted by GitBox <gi...@apache.org>.
stalary commented on code in PR #12513:
URL: https://github.com/apache/doris/pull/12513#discussion_r972550725
##########
gensrc/script/gen_build_version.sh:
##########
@@ -27,7 +27,13 @@
set -eo pipefail
-build_version="trunk"
+build_version_prefix="doris"
Review Comment:
Can it be specified at compile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary merged pull request #12513: [feature](http) refactor version info and add new http api for get version info
Posted by GitBox <gi...@apache.org>.
stalary merged PR #12513:
URL: https://github.com/apache/doris/pull/12513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on a diff in pull request #12513: [feature](http) refactor version info and add new http api for get version info
Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on code in PR #12513:
URL: https://github.com/apache/doris/pull/12513#discussion_r970392501
##########
gensrc/script/gen_build_version.sh:
##########
@@ -27,7 +27,13 @@
set -eo pipefail
-build_version="trunk"
+build_version_prefix="doris"
Review Comment:
yes, it needs modify version info manually in this commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org