[GitHub] [thrift] fishy opened a new pull request #2548: go: Decouple TDuplicateToProtocol out of TDebugProtocol

[GitBox <gi...@apache.org>]

fishy opened a new pull request #2548:
URL: https://github.com/apache/thrift/pull/2548


   Client: go
   
   Currently go's TDebugProtocol does two things: log the read/writes, and
   duplicate all the reads/writes to another TProtocol. For people who only
   need the second feature, even if they use NopLogger for the logging
   part, they still need to pay the price of all the fmt.Sprintf calls used
   by logging, and on some cases those fmt.Sprintf calls alone can cause
   significant CPU to be wasted (in one of our services fmt.Sprintf called
   by TDebugProtocol used ~10% of CPU).
   
   Create a dedicated TDuplicateToProtocol to reduce cpu waste, and mark
   TDebugProtocol.DuplicateTo as deprecated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy merged pull request #2548: THRIFT-5539: Decouple TDuplicateToProtocol out of TDebugProtocol

[GitBox <gi...@apache.org>]

fishy merged pull request #2548:
URL: https://github.com/apache/thrift/pull/2548


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org