[jira] Commented: (JCR-2756) Shareable node test failures

["Jukka Zitting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914445#action_12914445 ] 

Jukka Zitting commented on JCR-2756:
------------------------------------

I fixed the ShareableNodeTest class in revision 1000845 and marked the test failures as known issues. When fixing these failures, remember to remove the respective known.issues entries from jackrabbit-core/pom.xml.

> Shareable node test failures
> ----------------------------
>
>                 Key: JCR-2756
>                 URL: https://issues.apache.org/jira/browse/JCR-2756
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core, jackrabbit-jcr-tests
>    Affects Versions: 2.0.0, 2.1.0, 2.1.1
>            Reporter: Jukka Zitting
>
> There's a problem in the ShareableNodeTest class that makes it always throw NotExcecutableExceptions due to a null argument being passed to ensureKnowsNodeType(). The following patch fixes this problem:
> --- a/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/ShareableNodeTest.java
> +++ b/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/ShareableNodeTest.java
> @@ -45,8 +45,6 @@ import org.apache.jackrabbit.test.NotExecutableException;
>   */
>  public class ShareableNodeTest extends AbstractJCRTest {
>  
> -    private String mixShareable;
> -
>      protected void setUp() throws Exception {
>          super.setUp();
>          try {
> @@ -56,7 +54,6 @@ public class ShareableNodeTest extends AbstractJCRTest {
>              cleanUp();
>              throw e;
>          }
> -        mixShareable = superuser.getNamespacePrefix(NS_MIX_URI) + ":shareable";
>      }
>  
>      protected void tearDown() throws Exception {
> Once this patch is applied, we get the following test failures:
>   testGetName(org.apache.jackrabbit.test.api.ShareableNodeTest)
>   testGetNode(org.apache.jackrabbit.test.api.ShareableNodeTest)
>   testGetNodes(org.apache.jackrabbit.test.api.ShareableNodeTest)
>   testGetNodesByPattern(org.apache.jackrabbit.test.api.ShareableNodeTest)
> The problem seems to be caused by the ItemManager already having the non-shared version of a node cached when the mix:shareable mixin is added.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.