You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shethsh <gi...@git.apache.org> on 2014/09/07 18:57:20 UTC
[GitHub] spark pull request: Add ValueIncrementableHashMapAccumulator
GitHub user shethsh opened a pull request:
https://github.com/apache/spark/pull/2314
Add ValueIncrementableHashMapAccumulator
Value IncrementableHashMapAccumulator can be used in Spark Accumulator functionality to compute Histograms, distributions, complex metrics, etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shethsh/spark-1 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2314
----
commit bc6351b86b95c43bf35786ec28afe56032ffc006
Author: s <s...@h.corp.adobe.com>
Date: 2014-09-08T03:44:39Z
Add ValueIncrementableHashMapAccumulator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add ValueIncrementableHashMapAccumulator
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2314
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add ValueIncrementableHashMapAccumulator
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/2314#issuecomment-54913668
Thanks for the PR but this doesn't seem like something that needs to be in Spark -- we already have a histogram() implementation, and users can always build their own accumulator. I think that by the time people figure out this exists, they could've built their own class in this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add ValueIncrementableHashMapAccumulator
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2314#issuecomment-56287649
Let's close this issue, in that case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add ValueIncrementableHashMapAccumulator
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2314#issuecomment-54754171
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add ValueIncrementableHashMapAccumulator
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2314#issuecomment-54911616
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/6/consoleFull) for PR 2314 at commit [`bc6351b`](https://github.com/apache/spark/commit/bc6351b86b95c43bf35786ec28afe56032ffc006).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org