You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by an...@apache.org on 2023/04/04 06:21:24 UTC
[jackrabbit-oak] branch trunk updated: OAK-10170 : simplify usage of authorizableiterator (#885)
This is an automated email from the ASF dual-hosted git repository.
angela pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git
The following commit(s) were added to refs/heads/trunk by this push:
new e97bfb0036 OAK-10170 : simplify usage of authorizableiterator (#885)
e97bfb0036 is described below
commit e97bfb0036344b42f14d9093ac08b892d56f5a3f
Author: anchela <an...@apache.org>
AuthorDate: Tue Apr 4 08:21:16 2023 +0200
OAK-10170 : simplify usage of authorizableiterator (#885)
---
.../oak/security/user/AuthorizableImpl.java | 12 ++++++++----
.../oak/security/user/AuthorizableIterator.java | 20 +++++++++-----------
.../jackrabbit/oak/security/user/GroupImpl.java | 4 ++--
3 files changed, 19 insertions(+), 17 deletions(-)
diff --git a/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableImpl.java b/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableImpl.java
index f9647c8e4e..40d1c734ef 100644
--- a/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableImpl.java
+++ b/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableImpl.java
@@ -288,9 +288,13 @@ abstract class AuthorizableImpl implements Authorizable, UserConstants, TreeAwar
MembershipProvider mMgr = getMembershipProvider();
Iterator<Tree> trees = mMgr.getMembership(getTree(), includeInherited);
-
- AuthorizableIterator groups = (!trees.hasNext()) ? AuthorizableIterator.empty() : AuthorizableIterator.create(trees, userManager, AuthorizableType.GROUP);
- AuthorizableIterator allGroups = AuthorizableIterator.create(true, dynamicGroups, groups);
- return new RangeIteratorAdapter(allGroups);
+
+ if (!trees.hasNext()) {
+ return new RangeIteratorAdapter(AuthorizableIterator.create(true, dynamicGroups));
+ } else {
+ AuthorizableIterator groups = AuthorizableIterator.create(trees, userManager, AuthorizableType.GROUP);
+ AuthorizableIterator allGroups = AuthorizableIterator.create(true, dynamicGroups, groups);
+ return new RangeIteratorAdapter(allGroups);
+ }
}
}
diff --git a/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableIterator.java b/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableIterator.java
index 03be2bf3c6..b9b95f8e56 100644
--- a/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableIterator.java
+++ b/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/AuthorizableIterator.java
@@ -29,7 +29,6 @@ import org.slf4j.LoggerFactory;
import javax.jcr.RangeIterator;
import javax.jcr.RepositoryException;
-import java.util.Collections;
import java.util.HashSet;
import java.util.Iterator;
import java.util.Objects;
@@ -43,12 +42,10 @@ final class AuthorizableIterator implements Iterator<Authorizable> {
private static final Logger log = LoggerFactory.getLogger(AuthorizableIterator.class);
- private final Iterator<Authorizable> authorizables;
+ private final Iterator<? extends Authorizable> authorizables;
private final long size;
private final Set<String> servedIds;
-
- private static AuthorizableIterator EMPTY = new AuthorizableIterator(Collections.emptyIterator(), 0, false);
-
+
@NotNull
static AuthorizableIterator create(@NotNull Iterator<Tree> authorizableTrees,
@NotNull UserManagerImpl userManager,
@@ -57,6 +54,12 @@ final class AuthorizableIterator implements Iterator<Authorizable> {
long size = getSize(authorizableTrees);
return new AuthorizableIterator(it, size, false);
}
+
+ @NotNull
+ static AuthorizableIterator create(boolean filterDuplicates, @NotNull Iterator<? extends Authorizable> it1) {
+ long size = getSize(it1);
+ return new AuthorizableIterator(it1, size, filterDuplicates);
+ }
@NotNull
static AuthorizableIterator create(boolean filterDuplicates, @NotNull Iterator<? extends Authorizable> it1, @NotNull Iterator<? extends Authorizable> it2) {
@@ -72,13 +75,8 @@ final class AuthorizableIterator implements Iterator<Authorizable> {
}
return new AuthorizableIterator(Iterators.concat(it1, it2), size, filterDuplicates);
}
-
- @NotNull
- static AuthorizableIterator empty() {
- return EMPTY;
- }
- private AuthorizableIterator(Iterator<Authorizable> authorizables, long size, boolean filterDuplicates) {
+ private AuthorizableIterator(Iterator<? extends Authorizable> authorizables, long size, boolean filterDuplicates) {
if (filterDuplicates) {
this.servedIds = new HashSet<>();
this.authorizables = Iterators.filter(authorizables, authorizable -> {
diff --git a/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupImpl.java b/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupImpl.java
index 48076dcdb8..f41484ee0e 100644
--- a/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupImpl.java
+++ b/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/GroupImpl.java
@@ -213,13 +213,13 @@ class GroupImpl extends AuthorizableImpl implements Group {
DynamicMembershipProvider dmp = getUserManager().getDynamicMembershipProvider();
Iterator<Authorizable> dynamicMembers = dmp.getMembers(this, includeInherited);
if (dmp.coversAllMembers(this)) {
- return AuthorizableIterator.create(true, dynamicMembers, AuthorizableIterator.empty());
+ return AuthorizableIterator.create(true, dynamicMembers);
}
// dynamic membership didn't cover all members -> extract from group-tree
Iterator<Tree> trees = getMembershipProvider().getMembers(getTree(), includeInherited);
if (!trees.hasNext()) {
- return AuthorizableIterator.create(true, dynamicMembers, AuthorizableIterator.empty());
+ return AuthorizableIterator.create(true, dynamicMembers);
}
Iterator<Authorizable> members = AuthorizableIterator.create(trees, userMgr, AuthorizableType.AUTHORIZABLE);