You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ha...@apache.org on 2017/07/30 20:51:01 UTC
[04/23] flex-asjs git commit: stopPropogation on the goog BrowserEvent is needed. I don’t know if the stopImmediatePropagation on the real browser event actually does anything and I don’t know how to test.
stopPropogation on the goog BrowserEvent is needed.
I don’t know if the stopImmediatePropagation on the real browser event actually does anything and I don’t know how to test.
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/c14db8d7
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/c14db8d7
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/c14db8d7
Branch: refs/heads/develop
Commit: c14db8d7c1aaa5507c197ca1e07e08f53cee628d
Parents: 9d76666
Author: Harbs <ha...@in-tools.com>
Authored: Thu Jul 20 10:05:04 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Thu Jul 20 10:05:04 2017 +0300
----------------------------------------------------------------------
.../Core/src/main/flex/org/apache/flex/events/BrowserEvent.as | 2 +-
.../Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as | 3 +++
.../Core/src/main/flex/org/apache/flex/events/MouseEvent.as | 3 +++
3 files changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c14db8d7/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as
index d86fbd8..1c93b6b 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEvent.as
@@ -440,7 +440,7 @@ package org.apache.flex.events
public function stopImmediatePropagation():void
{
wrappedEvent.event_.stopImmediatePropagation(); // not in goog.events.BrowserEvent
- // wrappedEvent.stopPropagation();
+ wrappedEvent.stopPropagation();
}
/**
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c14db8d7/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as
index b89dbff..d4f6e18 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as
@@ -150,7 +150,10 @@ package org.apache.flex.events
override public function stopImmediatePropagation():void
{
if(wrappedEvent)
+ {
+ wrappedEvent.stopPropagation();
wrappedEvent["event_"].stopImmediatePropagation();
+ }
}
/**
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c14db8d7/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as
index 8231e20..fbd445c 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as
@@ -501,7 +501,10 @@ package org.apache.flex.events
override public function stopImmediatePropagation():void
{
if(wrappedEvent)
+ {
+ wrappedEvent.stopPropagation();
wrappedEvent["event_"].stopImmediatePropagation();
+ }
}
/**