[GitHub] [spark] sarutak commented on a change in pull request #33277: [SPARK-36068][BUILD][TEST] No tests in hadoop-cloud run unless hadoop-3.2 profile is activated explicitly

[GitBox <gi...@apache.org>]

sarutak commented on a change in pull request #33277:
URL: https://github.com/apache/spark/pull/33277#discussion_r667511662



##########
File path: hadoop-cloud/pom.xml
##########
@@ -201,13 +201,22 @@
   </dependencies>
 
   <profiles>
-
+    <!--
+     hadoop-3.2 profile is activated by default so hadoop-2.7 profile
+     also needs to be declared here for building with -Phadoop-2.7.
+    -->
+    <profile>
+      <id>hadoop-2.7</id>
+    </profile>
     <!--
      Hadoop 3 simplifies the classpath, and adds a new committer base class which
      enables store-specific committers.
     -->
     <profile>
       <id>hadoop-3.2</id>
+      <activation>
+        <activeByDefault>true</activeByDefault>

Review comment:
       I think it's true within each pom.
   https://maven.apache.org/ref/3.3.9/maven-model/apidocs/org/apache/maven/model/Activation.html#setActiveByDefault(boolean)
   
   In fact, tests run with `build/sbt -Phadoop-cloud -Pyarn -Phive -Phive-thriftserver -Pkubernetes "testOnly org.apache.spark.internal.io.cloud.*"`
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org