You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/28 02:34:05 UTC

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1994: feat(plugin): allowing cors to dynamically adapt to the BE rules

juzhiyuan commented on a change in pull request #1994:
URL: https://github.com/apache/apisix-dashboard/pull/1994#discussion_r677928888



##########
File path: web/src/components/Plugin/UI/cors.tsx
##########
@@ -40,8 +41,12 @@ export const FORM_ITEM_WITHOUT_LABEL = {
   },
 };
 
-const Cors: React.FC<Props> = ({ form }) => {
+const Cors: React.FC<Props> = ({ form, schema }) => {
   const { formatMessage } = useIntl();
+  const properties = schema?.properties

Review comment:
       If we don't pass `schema`, `properties` will be undefined 🤔 right?
   
   Should we have a check that this Property must be passed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org