[jira] [Commented] (HIVE-3560) Hive always prints a warning message when using remote metastore

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548034#comment-13548034 ] 

Hudson commented on HIVE-3560:
------------------------------

Integrated in Hive-trunk-hadoop2 #54 (See [https://builds.apache.org/job/Hive-trunk-hadoop2/54/])
    HIVE-3560 : Hive always prints a warning message when using remote metastore (Travis Crawford via Ashutosh Chauhan) (Revision 1409066)

     Result = ABORTED
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409066
Files : 
* /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
* /hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java

                
> Hive always prints a warning message when using remote metastore
> ----------------------------------------------------------------
>
>                 Key: HIVE-3560
>                 URL: https://issues.apache.org/jira/browse/HIVE-3560
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.10.0
>            Reporter: Travis Crawford
>            Assignee: Travis Crawford
>             Fix For: 0.10.0
>
>         Attachments: HIVE-3560_logging_tweaks.1.patch, HIVE-3560_logging_tweaks.2.patch
>
>
> This issue was discovered in HIVE-2585 and more details about why this issue was filed are available there.
> Currently if one sets {{hive.metastore.uris}} the following error will always be displayed:
> {code}
> 2012-07-24 15:23:58,647 [main] WARN org.apache.hadoop.hive.conf.HiveConf - DEPRECATED: Configuration property hive.metastore.local no longer has any effect. Make sure to provide a valid value for hive.metastore.uris if you are connecting to a remote metastore.
> {code}
> The reason is {{javax.jdo.option.ConnectionURL}} has a default value and will never be null. I set this property in {{hive-site.xml}} and walked through the configuration loading in a debugger. If the value is not empty it takes effect, and is ignored if empty.
> Since {{javax.jdo.option.ConnectionURL}} has a default and cannot be unset, this warning will always be printed if someone sets {{hive.metastore.uris}}.
> Per the review comments, the error message was added to reduce user confusion, and prevent surprises by using the wrong metastore (either embedded or remote). In {{HiveMetaStoreClient.java}} we see a very clear info message printed saying that a remote metastore is used.
> {code}
> LOG.info("Trying to connect to metastore with URI " + store);
> ...
> LOG.info("Connected to metastore.");
> {code}
> Since we clearly communicate to the user that a remote metastore at the given URI is being used we'll remove that message. Additionally, to further clarify a remote metastore is used I'll make the following HiveMetaStoreClient logging change:
> {code}
> LOG.debug("Trying to connect to remote HiveMetaStore: " + store);
> ...
> LOG.info("Connected to remote HiveMetaStore: " + store);
> {code}
> The change is at debug level we print connection attempts, and always print which remote HiveMetaStore we actually connected to.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira