You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/06/26 20:32:40 UTC

Review Request 35936: Windows unit tests: Server unit tests: fix the imports & failing patches

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35936/
-----------------------------------------------------------

Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Mahadev Konar.


Bugs: AMBARI-12038
    https://issues.apache.org/jira/browse/AMBARI-12038


Repository: ambari


Description
-------

Fixed the imports. Coalesced the OS mock. Excluded the obviously inapplicable Windows tests (Atlas, Ganglia, Kerberos, Mahout, NFSGateway, Phoenix, Ranger, Spark).


Diffs
-----

  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 4e130f9 
  ambari-agent/src/test/python/ambari_agent/TestActualConfigHandler.py 7f88e17 
  ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py d188dbd 
  ambari-agent/src/test/python/ambari_agent/TestController.py ba6e6c8 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 831ecce 
  ambari-agent/src/test/python/ambari_agent/TestDataCleaner.py 3ecb46a 
  ambari-agent/src/test/python/ambari_agent/TestFileCache.py da08782 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 58745f9 
  ambari-agent/src/test/python/ambari_agent/TestHostname.py 8cfcc96 
  ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py e9bb776 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 8c8d347 
  ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 3d8083b 
  ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py eb6dd29 
  ambari-agent/src/test/python/ambari_agent/TestSecurity.py c47172a 
  ambari-agent/src/test/python/ambari_agent/TestStatusCheck.py 32be4a8 
  ambari-common/src/test/python/only_for_platform.py 1b08db5 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_windows.py acb5bba 
  ambari-server/src/test/python/TestAmbariServer.py ce0747c 
  ambari-server/src/test/python/TestBootstrap.py 9c0e78e 
  ambari-server/src/test/python/TestValidateConfigs.py 1d1ddb4 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py e0ef2d7 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1 
  ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py c94dfa6 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 396b9d2 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 7d0afc7 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py c0a1686 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py a7e507e 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9ec3b01 
  ambari-server/src/test/python/stacks/2.2/ACCUMULO/test_accumulo_client.py 18c71e3 
  ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py 04e904a 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 105e741 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py 7300653 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 5413342 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 48358cc 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py db83824 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py d27aec2 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py 415527f 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py fd4c1ed 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py 6b61b1a 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 03d243c 

Diff: https://reviews.apache.org/r/35936/diff/


Testing
-------

mvn clean test on Linux and Windows


Thanks,

Florian Barca


Re: Review Request 35936: Windows unit tests: Server unit tests: fix the imports & failing patches

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On July 21, 2015, 5:30 p.m., Jayush Luniya wrote:
> > Ship It!

Verified patch on Mac


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35936/#review92437
-----------------------------------------------------------


On July 16, 2015, 10:36 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35936/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 10:36 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Mahadev Konar.
> 
> 
> Bugs: AMBARI-12038
>     https://issues.apache.org/jira/browse/AMBARI-12038
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed the imports. Coalesced the OS mock. Excluded the obviously inapplicable Windows tests (Atlas, Ganglia, Kerberos, Mahout, NFSGateway, Phoenix, Ranger, Spark).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_windows.py acb5bba8dd5bf92177531ca079c1490134045893 
>   ambari-server/src/test/python/TestAmbariServer.py db16927ccb9a259393a471f4f355aec026616dd7 
>   ambari-server/src/test/python/TestBootstrap.py bfeaa2fe6697225f230679219f26601344d43197 
>   ambari-server/src/test/python/TestValidateConfigs.py 1d1ddb4921b833d6f4d1ab7882236de061ac7ea9 
>   ambari-server/src/test/python/custom_actions/TestCheckHost.py 5b524d9e1265c587255ded7bc559fb120ec8f692 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py e85ee39bafea16d3d498bf06d774a6d29425a34c 
>   ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py c94dfa6a16ccefb1eeb61929069f069f272a3516 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 396b9d244d3e75aa485b7b4ea6ddc37b54f4f533 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 7d0afc747017702d570bd934ae0a496c5e38874e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 1711f69b69e6628ba0e687b043d7d1affc515510 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 37dcb205a878addc8a9c300b2e57646f328ce7f0 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9ec3b016f6540f18e9aab6b6a876cbfa3123833a 
>   ambari-server/src/test/python/stacks/2.2/ACCUMULO/test_accumulo_client.py fd97061a1db57e93c79fefe775c8d82e455e10f6 
>   ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py 3337e3fc966962687bb44d46a6fc229ce1b76a8c 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 105e741324f58896c11a8d291e771a7c0f782e1d 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py 730065373229696721a89c398d151da09bf53200 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 24c8afed498c6ad52946611f7e73b918b7f3033c 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py c2b826bb6faa4145a75ddb209c489f0502fe5b18 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 9cf1bd170682edbfdd4e2d8b5a8fbcd3d4efc446 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py deec6d68f2252afef6402447c25a196e91f4b34b 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py 415527f860e67fbb48d0f69080d6cec33469ba4c 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py fd4c1edcb38e1944a2ee0bd690d46d588079d008 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py de77efb073dbc437035df400e6c5d1f70ca5ca7c 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 03d243cfb713951e232d2cb771ff014e28189e10 
> 
> Diff: https://reviews.apache.org/r/35936/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test on Linux and Windows
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 35936: Windows unit tests: Server unit tests: fix the imports & failing patches

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35936/#review92437
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On July 16, 2015, 10:36 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35936/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 10:36 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Mahadev Konar.
> 
> 
> Bugs: AMBARI-12038
>     https://issues.apache.org/jira/browse/AMBARI-12038
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed the imports. Coalesced the OS mock. Excluded the obviously inapplicable Windows tests (Atlas, Ganglia, Kerberos, Mahout, NFSGateway, Phoenix, Ranger, Spark).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_windows.py acb5bba8dd5bf92177531ca079c1490134045893 
>   ambari-server/src/test/python/TestAmbariServer.py db16927ccb9a259393a471f4f355aec026616dd7 
>   ambari-server/src/test/python/TestBootstrap.py bfeaa2fe6697225f230679219f26601344d43197 
>   ambari-server/src/test/python/TestValidateConfigs.py 1d1ddb4921b833d6f4d1ab7882236de061ac7ea9 
>   ambari-server/src/test/python/custom_actions/TestCheckHost.py 5b524d9e1265c587255ded7bc559fb120ec8f692 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py e85ee39bafea16d3d498bf06d774a6d29425a34c 
>   ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py c94dfa6a16ccefb1eeb61929069f069f272a3516 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 396b9d244d3e75aa485b7b4ea6ddc37b54f4f533 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 7d0afc747017702d570bd934ae0a496c5e38874e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 1711f69b69e6628ba0e687b043d7d1affc515510 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 37dcb205a878addc8a9c300b2e57646f328ce7f0 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9ec3b016f6540f18e9aab6b6a876cbfa3123833a 
>   ambari-server/src/test/python/stacks/2.2/ACCUMULO/test_accumulo_client.py fd97061a1db57e93c79fefe775c8d82e455e10f6 
>   ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py 3337e3fc966962687bb44d46a6fc229ce1b76a8c 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 105e741324f58896c11a8d291e771a7c0f782e1d 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py 730065373229696721a89c398d151da09bf53200 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 24c8afed498c6ad52946611f7e73b918b7f3033c 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py c2b826bb6faa4145a75ddb209c489f0502fe5b18 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 9cf1bd170682edbfdd4e2d8b5a8fbcd3d4efc446 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py deec6d68f2252afef6402447c25a196e91f4b34b 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py 415527f860e67fbb48d0f69080d6cec33469ba4c 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py fd4c1edcb38e1944a2ee0bd690d46d588079d008 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py de77efb073dbc437035df400e6c5d1f70ca5ca7c 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 03d243cfb713951e232d2cb771ff014e28189e10 
> 
> Diff: https://reviews.apache.org/r/35936/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test on Linux and Windows
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 35936: Windows unit tests: Server unit tests: fix the imports & failing patches

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35936/
-----------------------------------------------------------

(Updated July 16, 2015, 10:36 p.m.)


Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Mahadev Konar.


Bugs: AMBARI-12038
    https://issues.apache.org/jira/browse/AMBARI-12038


Repository: ambari


Description
-------

Fixed the imports. Coalesced the OS mock. Excluded the obviously inapplicable Windows tests (Atlas, Ganglia, Kerberos, Mahout, NFSGateway, Phoenix, Ranger, Spark).


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_windows.py acb5bba8dd5bf92177531ca079c1490134045893 
  ambari-server/src/test/python/TestAmbariServer.py db16927ccb9a259393a471f4f355aec026616dd7 
  ambari-server/src/test/python/TestBootstrap.py bfeaa2fe6697225f230679219f26601344d43197 
  ambari-server/src/test/python/TestValidateConfigs.py 1d1ddb4921b833d6f4d1ab7882236de061ac7ea9 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py 5b524d9e1265c587255ded7bc559fb120ec8f692 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py e85ee39bafea16d3d498bf06d774a6d29425a34c 
  ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py c94dfa6a16ccefb1eeb61929069f069f272a3516 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 396b9d244d3e75aa485b7b4ea6ddc37b54f4f533 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 7d0afc747017702d570bd934ae0a496c5e38874e 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 1711f69b69e6628ba0e687b043d7d1affc515510 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py 37dcb205a878addc8a9c300b2e57646f328ce7f0 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9ec3b016f6540f18e9aab6b6a876cbfa3123833a 
  ambari-server/src/test/python/stacks/2.2/ACCUMULO/test_accumulo_client.py fd97061a1db57e93c79fefe775c8d82e455e10f6 
  ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py 3337e3fc966962687bb44d46a6fc229ce1b76a8c 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 105e741324f58896c11a8d291e771a7c0f782e1d 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py 730065373229696721a89c398d151da09bf53200 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 24c8afed498c6ad52946611f7e73b918b7f3033c 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py c2b826bb6faa4145a75ddb209c489f0502fe5b18 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 9cf1bd170682edbfdd4e2d8b5a8fbcd3d4efc446 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py deec6d68f2252afef6402447c25a196e91f4b34b 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py 415527f860e67fbb48d0f69080d6cec33469ba4c 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py fd4c1edcb38e1944a2ee0bd690d46d588079d008 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py de77efb073dbc437035df400e6c5d1f70ca5ca7c 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 03d243cfb713951e232d2cb771ff014e28189e10 

Diff: https://reviews.apache.org/r/35936/diff/


Testing
-------

mvn clean test on Linux and Windows


Thanks,

Florian Barca


Re: Review Request 35936: Windows unit tests: Server unit tests: fix the imports & failing patches

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35936/#review91974
-----------------------------------------------------------


git apply ~/Downloads/AMBARI-12038.0.patch
error: patch failed: ambari-server/src/test/python/custom_actions/TestInstallPackages.py:19
error: ambari-server/src/test/python/custom_actions/TestInstallPackages.py: patch does not apply
error: patch failed: ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py:18
error: ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py: patch does not apply

- Jayush Luniya


On June 26, 2015, 8:44 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35936/
> -----------------------------------------------------------
> 
> (Updated June 26, 2015, 8:44 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Mahadev Konar.
> 
> 
> Bugs: AMBARI-12038
>     https://issues.apache.org/jira/browse/AMBARI-12038
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fixed the imports. Coalesced the OS mock. Excluded the obviously inapplicable Windows tests (Atlas, Ganglia, Kerberos, Mahout, NFSGateway, Phoenix, Ranger, Spark).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_windows.py acb5bba8dd5bf92177531ca079c1490134045893 
>   ambari-server/src/test/python/TestAmbariServer.py ce0747c7e962139c44e5d9a48ec5367093c34e43 
>   ambari-server/src/test/python/TestBootstrap.py 9c0e78e65c9c4d19fe536e4e30408c7f35509378 
>   ambari-server/src/test/python/TestValidateConfigs.py 1d1ddb4921b833d6f4d1ab7882236de061ac7ea9 
>   ambari-server/src/test/python/custom_actions/TestCheckHost.py e0ef2d7808af8536ed4691276d41a1bb386db141 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 1e6dcead9e7eeee376528135eb2f4d6f1e28aeca 
>   ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py c94dfa6a16ccefb1eeb61929069f069f272a3516 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 396b9d244d3e75aa485b7b4ea6ddc37b54f4f533 
>   ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 7d0afc747017702d570bd934ae0a496c5e38874e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py c0a168658abf990a0a68e9af1451bdf5e05722ce 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py a7e507ec76a164056aead35a182a0be970ee327b 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9ec3b016f6540f18e9aab6b6a876cbfa3123833a 
>   ambari-server/src/test/python/stacks/2.2/ACCUMULO/test_accumulo_client.py 18c71e3757c69be7035aca8f461fa748253709d1 
>   ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py 04e904af3ecd18baa346cb570ab4804ccb86175c 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 105e741324f58896c11a8d291e771a7c0f782e1d 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py 730065373229696721a89c398d151da09bf53200 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 541334286d2865a053fb9b0ff653677326a6b53e 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 48358ccf677eecd75f77cdaa359f89fdd89332c8 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py db838244807f5e146586e79d50012336e02d66bd 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py d27aec2edecb41564a7fa7e1c416fd95c0b26135 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py 415527f860e67fbb48d0f69080d6cec33469ba4c 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py fd4c1edcb38e1944a2ee0bd690d46d588079d008 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py 6b61b1ab314956def2657c71df705da29a969b46 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 03d243cfb713951e232d2cb771ff014e28189e10 
> 
> Diff: https://reviews.apache.org/r/35936/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test on Linux and Windows
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 35936: Windows unit tests: Server unit tests: fix the imports & failing patches

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35936/
-----------------------------------------------------------

(Updated June 26, 2015, 8:44 p.m.)


Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Mahadev Konar.


Bugs: AMBARI-12038
    https://issues.apache.org/jira/browse/AMBARI-12038


Repository: ambari


Description
-------

Fixed the imports. Coalesced the OS mock. Excluded the obviously inapplicable Windows tests (Atlas, Ganglia, Kerberos, Mahout, NFSGateway, Phoenix, Ranger, Spark).


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_windows.py acb5bba8dd5bf92177531ca079c1490134045893 
  ambari-server/src/test/python/TestAmbariServer.py ce0747c7e962139c44e5d9a48ec5367093c34e43 
  ambari-server/src/test/python/TestBootstrap.py 9c0e78e65c9c4d19fe536e4e30408c7f35509378 
  ambari-server/src/test/python/TestValidateConfigs.py 1d1ddb4921b833d6f4d1ab7882236de061ac7ea9 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py e0ef2d7808af8536ed4691276d41a1bb386db141 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 1e6dcead9e7eeee376528135eb2f4d6f1e28aeca 
  ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py c94dfa6a16ccefb1eeb61929069f069f272a3516 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 396b9d244d3e75aa485b7b4ea6ddc37b54f4f533 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 7d0afc747017702d570bd934ae0a496c5e38874e 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py c0a168658abf990a0a68e9af1451bdf5e05722ce 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py a7e507ec76a164056aead35a182a0be970ee327b 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9ec3b016f6540f18e9aab6b6a876cbfa3123833a 
  ambari-server/src/test/python/stacks/2.2/ACCUMULO/test_accumulo_client.py 18c71e3757c69be7035aca8f461fa748253709d1 
  ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py 04e904af3ecd18baa346cb570ab4804ccb86175c 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 105e741324f58896c11a8d291e771a7c0f782e1d 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py 730065373229696721a89c398d151da09bf53200 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 541334286d2865a053fb9b0ff653677326a6b53e 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 48358ccf677eecd75f77cdaa359f89fdd89332c8 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py db838244807f5e146586e79d50012336e02d66bd 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py d27aec2edecb41564a7fa7e1c416fd95c0b26135 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py 415527f860e67fbb48d0f69080d6cec33469ba4c 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py fd4c1edcb38e1944a2ee0bd690d46d588079d008 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py 6b61b1ab314956def2657c71df705da29a969b46 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 03d243cfb713951e232d2cb771ff014e28189e10 

Diff: https://reviews.apache.org/r/35936/diff/


Testing
-------

mvn clean test on Linux and Windows


Thanks,

Florian Barca


Re: Review Request 35936: Windows unit tests: Server unit tests: fix the imports & failing patches

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35936/
-----------------------------------------------------------

(Updated June 26, 2015, 6:33 p.m.)


Review request for Ambari, Artem Baranchuk, Jayush Luniya, and Mahadev Konar.


Bugs: AMBARI-12038
    https://issues.apache.org/jira/browse/AMBARI-12038


Repository: ambari


Description
-------

Fixed the imports. Coalesced the OS mock. Excluded the obviously inapplicable Windows tests (Atlas, Ganglia, Kerberos, Mahout, NFSGateway, Phoenix, Ranger, Spark).


Diffs
-----

  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 4e130f9 
  ambari-agent/src/test/python/ambari_agent/TestActualConfigHandler.py 7f88e17 
  ambari-agent/src/test/python/ambari_agent/TestCertGeneration.py d188dbd 
  ambari-agent/src/test/python/ambari_agent/TestController.py ba6e6c8 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 831ecce 
  ambari-agent/src/test/python/ambari_agent/TestDataCleaner.py 3ecb46a 
  ambari-agent/src/test/python/ambari_agent/TestFileCache.py da08782 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 58745f9 
  ambari-agent/src/test/python/ambari_agent/TestHostname.py 8cfcc96 
  ambari-agent/src/test/python/ambari_agent/TestLiveStatus.py e9bb776 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 8c8d347 
  ambari-agent/src/test/python/ambari_agent/TestNetUtil.py 3d8083b 
  ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py eb6dd29 
  ambari-agent/src/test/python/ambari_agent/TestSecurity.py c47172a 
  ambari-agent/src/test/python/ambari_agent/TestStatusCheck.py 32be4a8 
  ambari-common/src/test/python/only_for_platform.py 1b08db5 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_windows.py acb5bba 
  ambari-server/src/test/python/TestAmbariServer.py ce0747c 
  ambari-server/src/test/python/TestBootstrap.py 9c0e78e 
  ambari-server/src/test/python/TestValidateConfigs.py 1d1ddb4 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py e0ef2d7 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1 
  ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py c94dfa6 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_monitor.py 396b9d2 
  ambari-server/src/test/python/stacks/2.0.6/GANGLIA/test_ganglia_server.py 7d0afc7 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py c0a1686 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py a7e507e 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_mysql_server.py 9ec3b01 
  ambari-server/src/test/python/stacks/2.2/ACCUMULO/test_accumulo_client.py 18c71e3 
  ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py 04e904a 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 105e741 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py 7300653 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 5413342 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 48358cc 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py db83824 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py d27aec2 
  ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_service_check.py 415527f 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py fd4c1ed 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py 6b61b1a 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py 03d243c 

Diff: https://reviews.apache.org/r/35936/diff/


Testing
-------

mvn clean test on Linux and Windows


Thanks,

Florian Barca