You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/11/18 13:07:15 UTC
[GitHub] [iotdb] EJTTianYu commented on a change in pull request #2070: Update level compaction delete and change list lock
EJTTianYu commented on a change in pull request #2070:
URL: https://github.com/apache/iotdb/pull/2070#discussion_r526071282
##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/level/LevelCompactionTsFileManagement.java
##########
@@ -338,12 +342,14 @@ public void recover() {
if (isSeq) {
for (TreeSet<TsFileResource> currMergeFile : sequenceTsFileResources
.get(timePartition)) {
- deleteLevelFiles(timePartition, currMergeFile);
+ deleteLevelFilesInDisk(currMergeFile);
+ deleteLevelFilesInList(timePartition, currMergeFile);
}
} else {
for (List<TsFileResource> currMergeFile : unSequenceTsFileResources
.get(timePartition)) {
- deleteLevelFiles(timePartition, currMergeFile);
+ deleteLevelFilesInDisk(currMergeFile);
+ deleteLevelFilesInList(timePartition, currMergeFile);
Review comment:
Why not combine these two statements into one function, because most of the time they appear at the same time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org