You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/04/20 13:29:06 UTC
[GitHub] [tomcat] prankkelkar opened a new pull request #276: Add s390x Travis support
prankkelkar opened a new pull request #276:
URL: https://github.com/apache/tomcat/pull/276
As Travis CI [officially supports](https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z) s390x builds, adding support for same.
Changes:
* Added s390x to build matrix
* Removed explicit steps to download java as they were redundant since using jdk tag from travis already provides expected java in the environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #276: Add s390x Travis support
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r412708978
##########
File path: .travis.yml
##########
@@ -15,8 +15,12 @@
dist: bionic
language: java
-jdk: oraclejdk8
-arch: arm64
+jobs:
+ include:
+ - arch: s390x
+ jdk: openjdk11
Review comment:
My concern is that Tomcat (even version 10.x) is supposed to be build with JDK 8.
But since Travis is not the main CI I think it is OK to use JDK 11 as an exception here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] prankkelkar commented on a change in pull request #276: Add s390x Travis support
Posted by GitBox <gi...@apache.org>.
prankkelkar commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r412705684
##########
File path: .travis.yml
##########
@@ -32,14 +36,7 @@ addons:
- libtool-bin
install:
- - ARCH=`uname -p`
- - echo $ARCH
- - JDK_X64="https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u242-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u242b08.tar.gz"
- - JDK_ARM64="https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_aarch64_linux_hotspot_8u232b09.tar.gz"
- - if test "X$ARCH" = "Xaarch64"; then JDK_URL=$JDK_ARM64; else JDK_URL=$JDK_X64; fi
- - wget -q $JDK_URL && tar xzf OpenJDK*.tar.gz
- - mv jdk8* jdk
- - export JAVA_HOME=`pwd`/jdk
Review comment:
I had shifted to use travis jdk to make things cleaner. Also since the version was exactly same i thought the steps were redundant. I will revert since you want keep it the way it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on a change in pull request #276: Add s390x Travis support
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r411923652
##########
File path: .travis.yml
##########
@@ -32,14 +36,7 @@ addons:
- libtool-bin
install:
- - ARCH=`uname -p`
- - echo $ARCH
- - JDK_X64="https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u242-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u242b08.tar.gz"
- - JDK_ARM64="https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_aarch64_linux_hotspot_8u232b09.tar.gz"
- - if test "X$ARCH" = "Xaarch64"; then JDK_URL=$JDK_ARM64; else JDK_URL=$JDK_X64; fi
- - wget -q $JDK_URL && tar xzf OpenJDK*.tar.gz
- - mv jdk8* jdk
- - export JAVA_HOME=`pwd`/jdk
Review comment:
The above was here for two reasons:
1) because TravisCI is really inconsistent in what is available in the different types of VMs
1.1) JAVA_HOME is exported for AMD64, but not for ARM64
1.2) `mvn` is available for AMD64, but not for ARM
1.3.) most important - to keep the version of the used JDK the same for all environments. The one provided by Travis for ARM64 was older than the one for AMD64
For the above reasons I'd prefer to keep the control
##########
File path: .travis.yml
##########
@@ -15,8 +15,12 @@
dist: bionic
language: java
-jdk: oraclejdk8
-arch: arm64
+jobs:
+ include:
+ - arch: s390x
+ jdk: openjdk11
Review comment:
any reason to use JDK 11 for s390x ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] prankkelkar commented on a change in pull request #276: Add s390x Travis support
Posted by GitBox <gi...@apache.org>.
prankkelkar commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r412706114
##########
File path: .travis.yml
##########
@@ -15,8 +15,12 @@
dist: bionic
language: java
-jdk: oraclejdk8
-arch: arm64
+jobs:
+ include:
+ - arch: s390x
+ jdk: openjdk11
Review comment:
JDK8 is very slow for s390x and causes test case failures due to timeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #276: Add s390x Travis support
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #276:
URL: https://github.com/apache/tomcat/pull/276#issuecomment-618421407
Thanks for the explanation, Rainer!
I've restarted the job at Travis. Let's see!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #276: Add s390x Travis support
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #276:
URL: https://github.com/apache/tomcat/pull/276#issuecomment-618443203
Thank you, @prankkelkar !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #276: Add s390x Travis support
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #276:
URL: https://github.com/apache/tomcat/pull/276#issuecomment-618402125
The build for s390x fails at Travis: https://travis-ci.org/github/apache/tomcat/jobs/678503882
```
Caused by: java.security.cert.CertificateExpiredException: NotAfter: Sat Dec 21 13:45:49 UTC 2019
at java.base/sun.security.x509.CertificateValidity.valid(CertificateValidity.java:274)
at java.base/sun.security.x509.X509CertImpl.checkValidity(X509CertImpl.java:675)
at java.base/sun.security.provider.certpath.BasicChecker.verifyValidity(BasicChecker.java:190)
at java.base/sun.security.provider.certpath.BasicChecker.check(BasicChecker.java:144)
at java.base/sun.security.provider.certpath.PKIXMasterCertPathValidator.validate(PKIXMasterCertPathValidator.java:125)
... 28 more
```
I have no idea what is going on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rainerjung commented on issue #276: Add s390x Travis support
Posted by GitBox <gi...@apache.org>.
rainerjung commented on issue #276:
URL: https://github.com/apache/tomcat/pull/276#issuecomment-618408120
Hi Martin,
the build.xml line numbers
/home/travis/build/apache/tomcat/build.xml:2789: The following error
occurred while executing this line:
/home/travis/build/apache/tomcat/build.xml:3124: The following error
occurred while executing this line:
/home/travis/build/apache/tomcat/build.xml:3240:
javax.net.ssl.SSLHandshakeException: PKIX path validation failed:
point at the commons-daemon download via an Apache mirror. So I guess
one of the mirrors uses an outdated certificate? If so, the error will
be intermittent, depending on which mirror is chosen.
Regards,
Rainer
Am 23.04.2020 um 15:44 schrieb Martin Grigorov:
> The build for s390x fails at Travis:
> https://travis-ci.org/github/apache/tomcat/jobs/678503882
>
> |Caused by: java.security.cert.CertificateExpiredException: NotAfter:
> Sat Dec 21 13:45:49 UTC 2019 at
> java.base/sun.security.x509.CertificateValidity.valid(CertificateValidity.java:274)
> at
> java.base/sun.security.x509.X509CertImpl.checkValidity(X509CertImpl.java:675)
> at
> java.base/sun.security.provider.certpath.BasicChecker.verifyValidity(BasicChecker.java:190)
> at
> java.base/sun.security.provider.certpath.BasicChecker.check(BasicChecker.java:144)
> at
> java.base/sun.security.provider.certpath.PKIXMasterCertPathValidator.validate(PKIXMasterCertPathValidator.java:125)
> ... 28 more |
>
> I have no idea what is going on.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tomcat/pull/276#issuecomment-618402125>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAFLGTZU5P7NWVXYYCGLWH3ROBA2TANCNFSM4MMOEBGA>.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org