You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/08 10:59:27 UTC

[GitHub] [airflow] feluelle commented on a change in pull request #11227: includes the STS token if STS credentials are used

feluelle commented on a change in pull request #11227:
URL: https://github.com/apache/airflow/pull/11227#discussion_r501630750



##########
File path: airflow/providers/amazon/aws/transfers/s3_to_redshift.py
##########
@@ -90,27 +93,39 @@ def __init__(
         self._s3_hook = None
         self._postgres_hook = None
 
+    def _build_copy_query(self, credentials, copy_options):

Review comment:
       I think so but where to put it? We don't have a `RedshiftHook` because most of it can be done via `PostgresHook`. In this case we could add `redshift.py` to `providers.amazon.aws.utils` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org