[GitHub] [nifi] hawko2600 commented on pull request #6432: Nifi 10436: Add brotli support to CompressContent

[GitBox <gi...@apache.org>]

hawko2600 commented on PR #6432:
URL: https://github.com/apache/nifi/pull/6432#issuecomment-1251903179

   Dear mods; NOTICE file already noted Brotli4j could be included. I added a blurb to the LICENSE file. Brotli is meant to be drop-in for gzip (it's effectively a smarter gzip) but I discovered after the fact it actually has compression levels that go all the way to 11. For now it's limited to the original 9 due to the way that parameter is implemented in CompressContent.java. Better to have format support in and get perfection later IMO. Brotli level 9 made fools out of every other compression format in the unit test files, I'm not sure 10 or 11 would be worth it due to the added latency when streaming.
   I also made the executive decision to call its MIME type application/x-brotli. It doesn't have an official one as far as I can tell, with the excuse it's meant for streaming not file data. This has been used by others to denote brotli compressed files as well, and as far as I know seems standards compliant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org