[GitHub] [trafficcontrol] srijeet0406 commented on a change in pull request #5450: When adding multiple interfaces on a server, a router host and router description should also be created per interface

[GitBox <gi...@apache.org>]

srijeet0406 commented on a change in pull request #5450:
URL: https://github.com/apache/trafficcontrol/pull/5450#discussion_r562951019



##########
File path: traffic_ops/app/db/migrations/2021011500000000_update_interfaces_multiple_routers.sql
##########
@@ -0,0 +1,53 @@
+/*
+
+    Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+
+        http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+*/
+
+-- +goose Up
+-- SQL in section 'Up' is executed when this migration is applied
+ALTER TABLE interface ADD COLUMN router_host_name text DEFAULT '';
+ALTER TABLE interface ADD COLUMN router_port text DEFAULT '';

Review comment:
       Checked with Jeff Howell, and he suggested keeping it as a string. I changed the name to be `router_port_name` though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org