[GitHub] [arrow-rs] alamb commented on a diff in pull request #3756: Zero-copy Vec conversion (#3516) (#1176)

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #3756:
URL: https://github.com/apache/arrow-rs/pull/3756#discussion_r1115795348


##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -269,6 +289,43 @@ impl Buffer {
                 length,
             })
     }
+
+    /// Returns `Vec` for mutating the buffer if this buffer is not offset and was
+    /// allocated with the correct layout for `Vec<T>`

Review Comment:
   I think it would be good to explicitly say here an error is returned if the buffer can't be converted to a Vec (and ideally hint how to get a Vec out of it anyways (perhaps by copying)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org