You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/04/14 03:35:21 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1427: [CELEBORN-523][REFACTOR] Remove unnecessary code in WorkerPartitionLocationInfo

AngersZhuuuu opened a new pull request, #1427:
URL: https://github.com/apache/incubator-celeborn/pull/1427

   ### What changes were proposed in this pull request?
   Remove unnecessary code
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1427: [CELEBORN-523][REFACTOR] Remove unnecessary code in WorkerPartitionLocationInfo

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1427:
URL: https://github.com/apache/incubator-celeborn/pull/1427#issuecomment-1507880790

   ping @waitinfuture @FMX


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1427: [CELEBORN-523][REFACTOR] Remove unnecessary code in WorkerPartitionLocationInfo

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1427:
URL: https://github.com/apache/incubator-celeborn/pull/1427#issuecomment-1507885978

   ## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1427?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1427](https://codecov.io/gh/apache/incubator-celeborn/pull/1427?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35919a7) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/3a2136226558f24093fbee8ee785b4f48d1741cc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a21362) will **increase** coverage by `0.04%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1427      +/-   ##
   ==========================================
   + Coverage   45.52%   45.56%   +0.04%     
   ==========================================
     Files         165      165              
     Lines       10519    10493      -26     
     Branches     1049     1045       -4     
   ==========================================
   - Hits         4788     4780       -8     
   + Misses       5397     5379      -18     
     Partials      334      334              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...born/common/meta/WorkerPartitionLocationInfo.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldGEvV29ya2VyUGFydGl0aW9uTG9jYXRpb25JbmZvLnNjYWxh) | `0.00% <ø> (ø)` | |
   
   ... and [4 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1427/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture merged pull request #1427: [CELEBORN-523][REFACTOR] Remove unnecessary code in WorkerPartitionLocationInfo

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1427:
URL: https://github.com/apache/incubator-celeborn/pull/1427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org