[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2615: [GOBBLIN-750] remove usage of depricated DatasetResolver and DatasetResolverFactory

[GitBox <gi...@apache.org>]

zxcware commented on a change in pull request #2615: [GOBBLIN-750] remove usage of depricated DatasetResolver and DatasetResolverFactory
URL: https://github.com/apache/incubator-gobblin/pull/2615#discussion_r301692876
 
 

 ##########
 File path: gobblin-api/src/main/java/org/apache/gobblin/dataset/DescriptorResolver.java
 ##########
 @@ -31,5 +31,20 @@
    * @param state configuration that helps resolve job specific descriptor
    * @return resolved descriptor for the job or {@code null} if failed to resolve
    */
-  Descriptor resolve(Descriptor raw, State state);
+  DatasetDescriptor resolve(DatasetDescriptor raw, State state);
 
 Review comment:
   Can we remove this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services