You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2016/11/03 23:19:58 UTC
[jira] [Commented] (SOLR-9360) Solr script not properly checking
SOLR_PID
[ https://issues.apache.org/jira/browse/SOLR-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634635#comment-15634635 ]
Erick Erickson commented on SOLR-9360:
--------------------------------------
OK, the grep -w option does match whole words only, so this works.
-D is a flag for grep (how universal I'm not sure) and at least one other place greps (incorrectly) just for jetty.port rather than jetty\.port so I'll just use the jetty\.port=$WOLR_PORT version
There's a couple of greps for "solr.solr.home" as well that I'll fix on the way by.
I took a brief look at the windows script and it uses another mechanism, so I'm not going to touch that one especially as I have no way to test it.
> Solr script not properly checking SOLR_PID
> ------------------------------------------
>
> Key: SOLR-9360
> URL: https://issues.apache.org/jira/browse/SOLR-9360
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
> Affects Versions: 6.1
> Reporter: Alessandro Benedetti
> Assignee: Erick Erickson
> Attachments: SOLR_9360.patch
>
>
> In the solr script we see in 3-4 areas this check :
> SOLR_PID=`ps auxww | grep start\.jar | grep -w $SOLR_PORT | grep -v grep | awk '{print $2}' | sort -r`
> This can potentially prevent a solr instance to start in the case another process by any chance contains the port int the command itself ( not necessarily actually using the port) .
> e.g.
> java -server -Djetty.port=10504 -DSTOP.PORT=9504 -DSTOP.KEY=solrrocks -DMASTER_CORE_URL=external-server:10500/solr -jar start.jar --module=http
> A solr is running on 10504.
> A new Solr will not be able to start on 10500 ( but actually the port is free).
> This should be replaced by a real check if the port is used ( like netstat or similar) .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org