You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/06 03:56:08 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #31051: Update sql-migration-guide.md
AngersZhuuuu opened a new pull request #31051:
URL: https://github.com/apache/spark/pull/31051
### What changes were proposed in this pull request?
Update migration guide according to https://github.com/apache/spark/pull/30942#issuecomment-755054562
### Why are the changes needed?
update migration guide.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755065420
**[Test build #133705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133705/testReport)** for PR 31051 at commit [`b28f4f9`](https://github.com/apache/spark/commit/b28f4f9317b6bd303a72369e76b769d1821c6eaa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755102358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755065420
**[Test build #133705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133705/testReport)** for PR 31051 at commit [`b28f4f9`](https://github.com/apache/spark/commit/b28f4f9317b6bd303a72369e76b769d1821c6eaa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755082689
**[Test build #133715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133715/testReport)** for PR 31051 at commit [`3013ece`](https://github.com/apache/spark/commit/3013ece2c99b4cd83be0a34928c76f53953c40ba).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755082689
**[Test build #133715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133715/testReport)** for PR 31051 at commit [`3013ece`](https://github.com/apache/spark/commit/3013ece2c99b4cd83be0a34928c76f53953c40ba).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755149782
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38303/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755086309
**[Test build #133715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133715/testReport)** for PR 31051 at commit [`3013ece`](https://github.com/apache/spark/commit/3013ece2c99b4cd83be0a34928c76f53953c40ba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755062187
FYI @cloud-fan @gatorsmile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755306962
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755116493
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38303/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755080864
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133705/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #31051:
URL: https://github.com/apache/spark/pull/31051#discussion_r552359426
##########
File path: docs/sql-migration-guide.md
##########
@@ -32,6 +32,8 @@ license: |
- In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no serde mode. In Spark 3.1 or earlier, the default FIELD DELIMIT is `\t`.
+ - In Spark 3.2, script transform default serde property `field.delim` is `\t` for Hive serde mode when user specifies serde. In Spark 3.1 or earlier, the default serde property `field.delim` is `\u0001` for Hive serde mode when user specifies serde.
Review comment:
> @AngersZhuuuu can you combine with the item above and clarify it together?
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755149782
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38303/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755102358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755080864
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133705/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755068893
**[Test build #133705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133705/testReport)** for PR 31051 at commit [`b28f4f9`](https://github.com/apache/spark/commit/b28f4f9317b6bd303a72369e76b769d1821c6eaa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31051:
URL: https://github.com/apache/spark/pull/31051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31051:
URL: https://github.com/apache/spark/pull/31051#issuecomment-755131538
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38303/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #31051: [SPARK-32685][SQL][FOLLOW-UP] Update migration guide about change default filed.delim to '\t' when user specifies serde
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31051:
URL: https://github.com/apache/spark/pull/31051#discussion_r552357381
##########
File path: docs/sql-migration-guide.md
##########
@@ -32,6 +32,8 @@ license: |
- In Spark 3.2, script transform default FIELD DELIMIT is `\u0001` for no serde mode. In Spark 3.1 or earlier, the default FIELD DELIMIT is `\t`.
+ - In Spark 3.2, script transform default serde property `field.delim` is `\t` for Hive serde mode when user specifies serde. In Spark 3.1 or earlier, the default serde property `field.delim` is `\u0001` for Hive serde mode when user specifies serde.
Review comment:
@AngersZhuuuu can you combine with the item above and clarify it together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org