You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/05/01 23:46:40 UTC
Review Request 66900: Avoid copying of re-register framework messages
in the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66900/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Prior to this patch, the re-register framework message was copied
into a subscribe call. This updates the handler to perform moves
instead.
Diffs
-----
src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4
src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47
Diff: https://reviews.apache.org/r/66900/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66900: Avoid copying of re-register framework
messages in the master.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66900/#review202260
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66860, 66900]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 1, 2018, 11:46 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66900/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 11:46 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, the re-register framework message was copied
> into a subscribe call. This updates the handler to perform moves
> instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4
> src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47
>
>
> Diff: https://reviews.apache.org/r/66900/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66900: Avoid copying of re-register framework
messages in the master.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66900/#review202248
-----------------------------------------------------------
PASS: Mesos patch 66900 was successfully built and tested.
Reviews applied: `['66860', '66900']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66900
- Mesos Reviewbot Windows
On May 1, 2018, 11:46 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66900/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 11:46 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, the re-register framework message was copied
> into a subscribe call. This updates the handler to perform moves
> instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4
> src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47
>
>
> Diff: https://reviews.apache.org/r/66900/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66900: Avoid copying of re-register framework
messages in the master.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66900/#review202430
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66860, 66900]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 4, 2018, 2:58 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66900/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 2:58 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, the re-register framework message was copied
> into a subscribe call. This updates the handler to perform moves
> instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4
> src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47
>
>
> Diff: https://reviews.apache.org/r/66900/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66900: Avoid copying of re-register framework
messages in the master.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66900/#review202405
-----------------------------------------------------------
PASS: Mesos patch 66900 was successfully built and tested.
Reviews applied: `['66860', '66900']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66900
- Mesos Reviewbot Windows
On May 4, 2018, 12:58 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66900/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 12:58 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, the re-register framework message was copied
> into a subscribe call. This updates the handler to perform moves
> instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4
> src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47
>
>
> Diff: https://reviews.apache.org/r/66900/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66900: Avoid copying of re-register framework
messages in the master.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66900/#review202484
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On May 4, 2018, 12:58 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66900/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 12:58 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, the re-register framework message was copied
> into a subscribe call. This updates the handler to perform moves
> instead.
>
>
> Diffs
> -----
>
> src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4
> src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47
>
>
> Diff: https://reviews.apache.org/r/66900/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66900: Avoid copying of re-register framework
messages in the master.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66900/
-----------------------------------------------------------
(Updated May 3, 2018, 5:58 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-8628
https://issues.apache.org/jira/browse/MESOS-8628
Repository: mesos
Description
-------
Prior to this patch, the re-register framework message was copied
into a subscribe call. This updates the handler to perform moves
instead.
Diffs (updated)
-----
src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4
src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47
Diff: https://reviews.apache.org/r/66900/diff/2/
Changes: https://reviews.apache.org/r/66900/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu