You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "amanraj2520 (via GitHub)" <gi...@apache.org> on 2023/02/20 09:55:32 UTC

[GitHub] [hive] amanraj2520 opened a new pull request, #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

amanraj2520 opened a new pull request, #4075:
URL: https://github.com/apache/hive/pull/4075

   The test is passing in my local. Not sure why is it failing on Jenkins. Anyways, I think it is just a CompactionID change so I don't think it is a major breaking change. This fix would fix it on Jenkins build.
   The test fails due to the following Assertion ERROR :
   Client Execution succeeded but contained differences (error code = 1) after executing dbtxnmgr_showlocks.q
   73c73
   < 5 default partitioned_acid_table p=abc MINOR initiated — --- — ---
   —
   > 1 default partitioned_acid_table p=abc MINOR initiated — --- — ---
    
   It expects a Compaction ID 1 but gets 5.
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1456393705

   @zabetak Gentle reminder. Can you please review this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1454808053

   @zabetak Can you please review and merge this. Somehow the space was not getting committed from my local machine. Now the test is passing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1442147181

   Sure will do


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1436663246

   @abstractdog @zabetak Can you please review this. This test passes on my local


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1441737078

   @amanraj2520 Let's update it to 5 for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak closed pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q
URL: https://github.com/apache/hive/pull/4075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1438238558

   Hi @zabetak You were right. I was able to repro this. I agree we need to fix this in master. Investigating this. Here is the list of test cases that run before this test : https://drive.google.com/file/d/1wCe6ZLU42xYD2gr3oNc_6rS35xVl3T6c/view?usp=sharing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1439855199

   @amanraj2520 I would suggest to make use of `--! qt:replace` option to mask the compaction id since I don't think it is important for the test case. Please create a new JIRA for master with proper summary and description (including your analysis here) and then create a PR for it.
   
   After that this becomes a simple backport.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1438484077

   @zabetak the last test which impacts this CompactionID is dbtxnmgr_compact3.q. I deleted this test and ran the entire split. The compactionId comes as 4
   ![image](https://user-images.githubusercontent.com/104416558/220356264-19de8058-6d46-46ad-a695-39a19f68693c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1442091264

   @zabetak In that case can you please merge this PR if it looks good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1440556029

   Hi @zabetak I tried to use the  '--! qt:replace' option but the issue is that in branch-3 we do not have the commit which added QTestReplaceHandler.java. This was done in HIVE-22297. But backport HIVE-22297 is not straightforward. We need to backport multiple JIRAs in order to have a clean backport. And only a single test is failing because of this in branch-3. So I think we can either remove the show compactions or update it to 5 for now.
   
   Having said that, I will raise a ticket in master to ensure this is taken care of there. Please let me know if this sounds good or should we spend some time in backporting all the qtest related changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] amanraj2520 commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "amanraj2520 (via GitHub)" <gi...@apache.org>.
amanraj2520 commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1438545855

   @zabetak dbtxnmgr_compact1.q (increments by 1), dbtxnmgr_compact2.q (increments by 2) and dbtxnmgr_compact3.q (increments by 1) And then dbtxnmgr_showlocks.q runs which gets CompactionID as 5. Can you please suggest should we remove the show compactions statement or should I write a separate CliDriver only for this dbtxnmgr_showlocks.q which would run it as a separate test.
   
   Also, "show compactions" is only present in this test only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] zabetak commented on pull request #4075: HIVE-27096 : Fix test dbtxnmgr_showlocks.q

Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #4075:
URL: https://github.com/apache/hive/pull/4075#issuecomment-1442122627

   @amanraj2520 The test currently fails. You seem to have missed some white space changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org