[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6127: Rewrite possible array aggregation functions to one level

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #6127:
URL: https://github.com/apache/incubator-pinot/pull/6127#discussion_r504830479



##########
File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -343,6 +346,9 @@ private static void queryRewrite(PinotQuery pinotQuery) {
     // Invoke compilation time functions
     invokeCompileTimeFunctions(pinotQuery);
 
+    // Rewrite Selection list
+    rewriteSelections(pinotQuery.getSelectList());

Review comment:
       We found that the query compilation time for SQL has gone up to 5ms in certain cases (as compared to micro-seconds for PQL). One suspect here is the additional processing like these.
   
   Tagging @siddharthteotia to share the findings.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org