You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/11/21 14:05:18 UTC

[GitHub] [servicecomb-kie] little-cui commented on a diff in pull request #267: rbac增加弱校验；修复无get权限时，获取配置列表报错.

little-cui commented on code in PR #267:
URL: https://github.com/apache/servicecomb-kie/pull/267#discussion_r1028079514


##########
server/config/struct.go:
##########
@@ -50,8 +50,10 @@ type DB struct {
 
 // RBAC is rbac config
 type RBAC struct {
-	Enabled    bool   `yaml:"enabled"`
-	PubKeyFile string `yaml:"rsaPublicKeyFile"`
+	Enabled        bool `yaml:"enabled"`
+	AllowMissToken bool `yaml:"allowMissToken"`
+	SkipAuth       bool

Review Comment:
   不应该定义新的概念，enabled和allow参数已经可以满足判断的需求



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org