You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "sigee (via GitHub)" <gi...@apache.org> on 2024/07/04 16:05:13 UTC
[PR] Fix documentation [commons-csv]
sigee opened a new pull request, #439:
URL: https://github.com/apache/commons-csv/pull/439
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation [commons-csv]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #439: Fix documentation
URL: https://github.com/apache/commons-csv/pull/439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation [commons-csv]
Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert commented on code in PR #439:
URL: https://github.com/apache/commons-csv/pull/439#discussion_r1665904498
##########
CONTRIBUTING.md:
##########
@@ -41,7 +41,7 @@
Contributing to Apache Commons CSV
======================
-You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to
+You have found a bug, or you have an idea for a cool new feature? Contributing code is a great way to give something back to
Review Comment:
This is auto generated text so this is not the place to fix this. Can you revert please.
##########
pom.xml:
##########
@@ -404,6 +404,13 @@
</plugin>
</plugins>
</reporting>
+ <repositories>
Review Comment:
This repository is already included from the parent pom: org.apache:apache
##########
pom.xml:
##########
@@ -44,7 +44,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
- <version>4.11.0</version>
+ <version>5.11.0</version>
Review Comment:
I am not sure why you are upgrading this dependency; the pr has no use of this plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation [commons-csv]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #439:
URL: https://github.com/apache/commons-csv/pull/439#discussion_r1665942716
##########
pom.xml:
##########
@@ -44,7 +44,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
- <version>4.11.0</version>
+ <version>5.11.0</version>
Review Comment:
Worse, it's not compatible with Java 8 🙁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation [commons-csv]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #439:
URL: https://github.com/apache/commons-csv/pull/439#issuecomment-2210924171
Closing, see comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation [commons-csv]
Posted by "aherbert (via GitHub)" <gi...@apache.org>.
aherbert commented on code in PR #439:
URL: https://github.com/apache/commons-csv/pull/439#discussion_r1665924494
##########
src/main/java/org/apache/commons/csv/Lexer.java:
##########
@@ -467,7 +469,7 @@ boolean readEndOfLine(int ch) throws IOException {
* On return, the next character is available by calling {@link ExtendedBufferedReader#getLastChar()}
* on the input stream.
*
- * @return the unescaped character (as an int) or {@link Constants#EOF} if char following the escape is
+ * @return the unescaped character (as an int) or {@link IOUtils#EOF} if char following the escape is
Review Comment:
```{@link org.apache.commons.io.IOUtils#EOF IOUtils.EOF}```
##########
src/main/java/org/apache/commons/csv/Lexer.java:
##########
@@ -22,6 +22,8 @@
import java.io.Closeable;
import java.io.IOException;
+import org.apache.commons.io.IOUtils;
Review Comment:
We do not require this import for the code. You can use it directly in the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix documentation [commons-csv]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #439:
URL: https://github.com/apache/commons-csv/pull/439#discussion_r1665942716
##########
pom.xml:
##########
@@ -44,7 +44,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
- <version>4.11.0</version>
+ <version>5.11.0</version>
Review Comment:
Worse, it's not compatible with Java 8 🙁 We use Dependabot for updates like these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org