[GitHub] nwangtw closed pull request #3153: Update metrics section in Heron UI

[GitBox <gi...@apache.org>]

nwangtw closed pull request #3153: Update metrics section in Heron UI
URL: https://github.com/apache/incubator-heron/pull/3153
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/heron/tools/ui/resources/static/js/stat-trendlines.js b/heron/tools/ui/resources/static/js/stat-trendlines.js
index bba30f914d..b9f59e8066 100644
--- a/heron/tools/ui/resources/static/js/stat-trendlines.js
+++ b/heron/tools/ui/resources/static/js/stat-trendlines.js
@@ -207,10 +207,8 @@ function StatTrendlines(baseUrl, cluster, environ, toponame, physicalPlan, logic
     } else if (instance === '*') {
       d3.select('#trendline-title').text(name + ' Metrics');
     } else {
-      d3.select('#trendline-title').text('Instance Metrics');
-    }
+      d3.select('#trendline-title').text(instance + ' Metrics');
 
-    if (instance !== '*') {
       container = instance.split("_")[1];
       target
         .append('div')
@@ -220,7 +218,6 @@ function StatTrendlines(baseUrl, cluster, environ, toponame, physicalPlan, logic
           '<a class="btn btn-primary btn-xs" target="_blank" href="/topologies/filestats/' + cluster + '/' + environ + '/' + toponame + '/' + container + '">job</a>',
           '<a class="btn btn-primary btn-xs" target="_blank" href="/topologies/' + cluster + '/' + environ + '/' + toponame + '/' + name + '/' + instance + '/exceptions">exceptions</a>',
           '<br>',
-          instance
         ].join(' '));
     }
   };


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services