You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/27 10:25:15 UTC
[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request, #1358: MINIFICPP-1873 - Fix state management path config typo in minifi.prop…
arpadboda opened a new pull request, #1358:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1358
…erties file
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1358: MINIFICPP-1873 - Fix state management path config typo in minifi.prop…
Posted by GitBox <gi...@apache.org>.
martinzink closed pull request #1358: MINIFICPP-1873 - Fix state management path config typo in minifi.prop…
URL: https://github.com/apache/nifi-minifi-cpp/pull/1358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1358: MINIFICPP-1873 - Fix state management path config typo in minifi.prop…
Posted by GitBox <gi...@apache.org>.
lordgamez commented on code in PR #1358:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1358#discussion_r907229496
##########
conf/minifi.properties:
##########
@@ -48,7 +48,7 @@ nifi.content.repository.class.name=DatabaseContentRepository
## that implements CoreComponentStateManagementProvider
## (e.g. an instance of RocksDbPersistableKeyValueStoreService or UnorderedMapPersistableKeyValueStoreService)
#nifi.state.management.provider.local=
-#nifi.state.manangement.provider.local.path=
+#nifi.state.management.provider.local.path=
Review Comment:
I've found 2 more appearances of this type in CONFIGURE.md we should fix those as well.
##########
conf/minifi.properties:
##########
@@ -48,7 +48,7 @@ nifi.content.repository.class.name=DatabaseContentRepository
## that implements CoreComponentStateManagementProvider
## (e.g. an instance of RocksDbPersistableKeyValueStoreService or UnorderedMapPersistableKeyValueStoreService)
#nifi.state.management.provider.local=
-#nifi.state.manangement.provider.local.path=
+#nifi.state.management.provider.local.path=
Review Comment:
I've found 2 more appearances of this typo in CONFIGURE.md we should fix those as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda commented on a diff in pull request #1358: MINIFICPP-1873 - Fix state management path config typo in minifi.prop…
Posted by GitBox <gi...@apache.org>.
arpadboda commented on code in PR #1358:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1358#discussion_r907232931
##########
conf/minifi.properties:
##########
@@ -48,7 +48,7 @@ nifi.content.repository.class.name=DatabaseContentRepository
## that implements CoreComponentStateManagementProvider
## (e.g. an instance of RocksDbPersistableKeyValueStoreService or UnorderedMapPersistableKeyValueStoreService)
#nifi.state.management.provider.local=
-#nifi.state.manangement.provider.local.path=
+#nifi.state.management.provider.local.path=
Review Comment:
Thanks, amended those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org