You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/19 06:34:56 UTC

[GitHub] [apisix-docker] Yiyiyimu commented on pull request #159: feat: automate upload image to Dockerhub

Yiyiyimu commented on pull request #159:
URL: https://github.com/apache/apisix-docker/pull/159#issuecomment-822209422


   @qian0817 Thank you for the contribution! It really helps a lot!! BTW, do you mind adding another documentation like `MAINTAINING.md` to remind maintainers to make a release when they upgrade to the new version?
   
   @starsz Yes this PR fulfills the requirement, by directly using docker itself but not docker in actions. So no more things need to be done.
   
   Hi @gxthrj It seems we do not (I haven't found related information about) store dockerhub username and password in secrets, but we directly use them here. I think we need to upload it to secrets in this repo when you got time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org