[GitHub] [superset] villebro commented on a change in pull request #16592: fix: Remove export CSV in old filter box

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #16592:
URL: https://github.com/apache/superset/pull/16592#discussion_r702834399



##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
##########
@@ -328,16 +328,20 @@ class SliceHeaderControls extends React.PureComponent<
           {t('Download as image')}
         </Menu.Item>
 
-        {this.props.supersetCanCSV && (
-          <Menu.Item key={MENU_KEYS.EXPORT_CSV}>{t('Export CSV')}</Menu.Item>
-        )}
-        {isFeatureEnabled(FeatureFlag.ALLOW_FULL_CSV_EXPORT) &&
+        {this.props.slice.viz_type !== 'filter_box' &&

Review comment:
       Future improvement idea: maybe we should have a property `enableExportCSV` on `ChartMetadata` which defaults to `true`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org