You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Mark Chu-Carroll <mc...@twitter.com> on 2013/12/16 23:19:29 UTC
Review Request 16306: "job status" command, with wildcard support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/
-----------------------------------------------------------
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Repository: aurora
Description
-------
Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
This also includes unit tests of the new command.
Diffs
-----
src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
Diff: https://reviews.apache.org/r/16306/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Mark Chu-Carroll <mc...@twitter.com>.
> On Dec. 17, 2013, 6:14 p.m., Brian Wickman wrote:
> > src/main/python/twitter/aurora/client/cli/jobs.py, line 130
> > <https://reviews.apache.org/r/16306/diff/1/?file=398463#file398463line130>
> >
> > not sure if a schema was defined in the designdoc, but any reason not to just use TJSONProtocol.TSimpleJSONProtocol and convert directly from thrift to json here?
I ended up being a bit more baroque here; even TSimpleJSONProtocol doesn't do prettyprinting; it generates compact JSON with no whitespace. So I'm grabbing the output from thrift, scarfing it up through python's json library, and then prettyprinting it.
> On Dec. 17, 2013, 6:14 p.m., Brian Wickman wrote:
> > src/main/python/twitter/aurora/client/cli/jobs.py, lines 150-155
> > <https://reviews.apache.org/r/16306/diff/1/?file=398463#file398463line150>
> >
> > yikes -- a leaky abstraction! we should re-file AURORA-3280 externally.
This looked sufficiently neutered to me that I assumed it was a deliberate stub.
> On Dec. 17, 2013, 6:14 p.m., Brian Wickman wrote:
> > src/main/python/twitter/aurora/client/cli/jobs.py, line 217
> > <https://reviews.apache.org/r/16306/diff/1/?file=398463#file398463line217>
> >
> > meta-question: does it make sense to put a logger on the context instead of using print? (even if the logger _is_ print?)
Excellent idea!
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review30575
-----------------------------------------------------------
On Dec. 16, 2013, 5:19 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 5:19 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
> src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
> src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
> src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Brian Wickman <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review30575
-----------------------------------------------------------
src/main/python/twitter/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment58547>
parts = key.split('/')
also should probably do a validation here to make sure that len(parts) <= 4
src/main/python/twitter/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment58548>
return PartialJobKey(*parts)
src/main/python/twitter/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment58549>
this would be much more powerful if you could use fnmatch, e.g. us-west/macaw*/test/*staging* rather than just us-west/*
this should be pretty easy to do. if any of '*?[]' are in the string then it's not fully bound, instead of just == '*'
then you can use fnmatch.filter() to do the matches rather than component == '*' or key.component == component
src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment58550>
not sure if a schema was defined in the designdoc, but any reason not to just use TJSONProtocol.TSimpleJSONProtocol and convert directly from thrift to json here?
src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment58551>
yikes -- a leaky abstraction! we should re-file AURORA-3280 externally.
src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment58554>
snake_case instead of camelCase (even though the thrift is camel.)
also, instead of
foo_str += '\nbar'
foo_str += '\n\tbaz'
repeatedly, it's more performant (O(n) vs O(n^2)) to do
foo_strs = []
foo_strs.append('bar')
foo_strs.append('\tbaz')
...
then return '\n'.join(foo_strs)
src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment58552>
indent here is weird
src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment58555>
doubleyikes
src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment58559>
meta-question: does it make sense to put a logger on the context instead of using print? (even if the logger _is_ print?)
- Brian Wickman
On Dec. 16, 2013, 10:19 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 10:19 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
> src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
> src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
> src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31163
-----------------------------------------------------------
beep beep - this has been sitting for more than two weeks! Can someone please just take a look?
- Mark Chu-Carroll
On Dec. 18, 2013, 4:27 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 4:27 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
> src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
> src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
> src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Brian Wickman <wi...@gmail.com>.
> On Jan. 3, 2014, 9:47 p.m., Brian Wickman wrote:
> > src/main/python/twitter/aurora/client/cli/jobs.py, lines 183-184
> > <https://reviews.apache.org/r/16306/diff/2/?file=399575#file399575line183>
> >
> > use list(filter(...)) or []-comprehension here since filter() is lazy in python3, so len() won't work on it. (render_tasks_pretty calls len() on the iterable)
>
> Mark Chu-Carroll wrote:
> This filter statement is still part of the status command for the old client; should that be changed as well? Or don't mess with what's not broken?
I think we're fine with the status quo here as mesos core itself does not yet support Python 3, and I figure client v2 will be out before it does.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31166
-----------------------------------------------------------
On Dec. 18, 2013, 9:27 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 9:27 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
> src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
> src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
> src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
> On Jan. 3, 2014, 4:47 p.m., Brian Wickman wrote:
> > src/main/python/twitter/aurora/client/cli/jobs.py, lines 183-184
> > <https://reviews.apache.org/r/16306/diff/2/?file=399575#file399575line183>
> >
> > use list(filter(...)) or []-comprehension here since filter() is lazy in python3, so len() won't work on it. (render_tasks_pretty calls len() on the iterable)
This filter statement is still part of the status command for the old client; should that be changed as well? Or don't mess with what's not broken?
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31166
-----------------------------------------------------------
On Dec. 18, 2013, 4:27 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 4:27 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
> src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
> src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
> src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Brian Wickman <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31166
-----------------------------------------------------------
src/main/python/twitter/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment59544>
I think this check is not quite right. It should be more like:
return not any('*' in component for component in (key.cluster, key.role, key.env, key.name))
src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment59546>
strip off all the \n\t's and do '\n\t'.join(...) ?
src/main/python/twitter/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment59547>
use list(filter(...)) or []-comprehension here since filter() is lazy in python3, so len() won't work on it. (render_tasks_pretty calls len() on the iterable)
- Brian Wickman
On Dec. 18, 2013, 9:27 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 9:27 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
> src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
> src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
> src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Jonathan Boulle <jo...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31422
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment59903>
please standardise on having or not having a newline before the closing """ of a multiline docstring (personally I prefer it, but most other places you omit it, so w/e)
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment59896>
s/Open/Opens for consistency with other docstrings
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment59897>
turn this into a docstring?
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment59898>
s/Get/Gets/
also s/all //
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment59899>
should TODOs still be attributed?
src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/16306/#comment59900>
kill
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment59901>
print_err doesn't appear to take a file kwarg
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment59902>
inconsistency here checking the truthiness of job_tasks... can you just ensure job_tasks is a list so you don't have to bother? (e.g. get_job_status returns [], never None)
- Jonathan Boulle
On Jan. 8, 2014, 10:32 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 10:32 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31472
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/jobs.py
<https://reviews.apache.org/r/16306/#comment59968>
Thanks, good catch.
- Mark Chu-Carroll
On Jan. 8, 2014, 5:32 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 5:32 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Jonathan Boulle <jo...@twitter.com>.
> On Jan. 13, 2014, 3:24 p.m., Mark Chu-Carroll wrote:
> > Ping?
er, is this totally subsumed by https://reviews.apache.org/r/16423/diff/#index_header , or am I missing something?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31616
-----------------------------------------------------------
On Jan. 9, 2014, 10:29 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 10:29 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
> On Jan. 13, 2014, 10:24 a.m., Mark Chu-Carroll wrote:
> > Ping?
>
> Jonathan Boulle wrote:
> er, is this totally subsumed by https://reviews.apache.org/r/16423/diff/#index_header , or am I missing something?
This really is a separate change; 16423 builds on it.
wickman asked me to update the diffs on that one so that they're relative to this; the latest diffs in 16423 should show the differences against this.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31616
-----------------------------------------------------------
On Jan. 9, 2014, 5:29 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 5:29 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Jonathan Boulle <jo...@twitter.com>.
> On Jan. 13, 2014, 3:24 p.m., Mark Chu-Carroll wrote:
> > Ping?
>
> Jonathan Boulle wrote:
> er, is this totally subsumed by https://reviews.apache.org/r/16423/diff/#index_header , or am I missing something?
>
> Mark Chu-Carroll wrote:
> This really is a separate change; 16423 builds on it.
> wickman asked me to update the diffs on that one so that they're relative to this; the latest diffs in 16423 should show the differences against this.
I don't see that; for example, print_out and print_err are showing up as new code in both diffs.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31616
-----------------------------------------------------------
On Jan. 9, 2014, 10:29 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 10:29 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31616
-----------------------------------------------------------
Ping?
- Mark Chu-Carroll
On Jan. 9, 2014, 5:29 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 5:29 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
> src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
> src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
> src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
> src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
> src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
> src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
> src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
> src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
> src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/
-----------------------------------------------------------
(Updated Jan. 9, 2014, 5:29 p.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Changes
-------
Addressing jboulle's review.
Repository: aurora
Description
-------
Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
This also includes unit tests of the new command.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
Diff: https://reviews.apache.org/r/16306/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/
-----------------------------------------------------------
(Updated Jan. 8, 2014, 5:32 p.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Changes
-------
Addressed reviews, and updated to fit with the recent change from twitter.aurora to apache.aurora.
Repository: aurora
Description
-------
Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
This also includes unit tests of the new command.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/__init__.py 2c08cf985a3ad9126a544596f895540524af865c
src/main/python/apache/aurora/client/cli/context.py c50f1a15847f5374a30d6bc93915123d8471e4aa
src/main/python/apache/aurora/client/cli/jobs.py b789361313e279ac8398a92a46ec724c09fb4513
src/main/python/apache/aurora/client/cli/options.py 80fabb93945f38011b1e9c64ed20f8035ec146fa
src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION
src/test/python/apache/aurora/client/cli/BUILD 9528eed70e76431f720c4a26651ae0729903288c
src/test/python/apache/aurora/client/cli/test_create.py df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54
src/test/python/apache/aurora/client/cli/test_kill.py 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773
src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION
src/test/python/apache/aurora/client/cli/util.py c6d38304fb8ac89b9a175d8c20438a8831f784df
src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION
Diff: https://reviews.apache.org/r/16306/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Brian Wickman <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/#review31397
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Dec. 18, 2013, 9:27 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16306/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2013, 9:27 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
>
> This also includes unit tests of the new command.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
> src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
> src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
> src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
> src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
>
> Diff: https://reviews.apache.org/r/16306/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16306: "job status" command, with wildcard support.
Posted by Mark Chu-Carroll <mc...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16306/
-----------------------------------------------------------
(Updated Dec. 18, 2013, 4:27 p.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Changes
-------
Addressed reviews:
- fixed lots of stuff;
- using fmatch for unix-style globbing;
- using thrift serialization for status;
- moved printing into the context.
Repository: aurora
Description
-------
Added an implementation of the "status" verb for jobs. This is the first command to use the new job wildcards, so there's a bunch of infrastructure added to the Context to support it.
This also includes unit tests of the new command.
Diffs (updated)
-----
src/main/python/twitter/aurora/client/api/__init__.py 60f4011dda0db17ed57d3499637270d466c1b0b8
src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
src/main/python/twitter/aurora/client/cli/context.py 2ae92ecce8ec3ee2bf66b727e19bc90d1c171eb9
src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
src/test/python/twitter/aurora/client/cli/BUILD 89184b649f8c7807a6f599d6f0026902eed11a6c
src/test/python/twitter/aurora/client/cli/test_create.py da2828f73d32e3d3305fddd4224014a9b847ad2a
src/test/python/twitter/aurora/client/cli/test_kill.py 8f8095cd2d1dac9d6d2a9891db16cce1d4227eaf
src/test/python/twitter/aurora/client/cli/test_status.py PRE-CREATION
src/test/python/twitter/aurora/client/cli/util.py 46883ecd696b0f6b691831b65bb5e71367cd652a
Diff: https://reviews.apache.org/r/16306/diff/
Testing
-------
Thanks,
Mark Chu-Carroll