You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jeremy Thomerson (JIRA)" <ji...@apache.org> on 2009/03/26 20:40:50 UTC
[jira] Commented: (WICKET-670) Bring back the inspector!
[ https://issues.apache.org/jira/browse/WICKET-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689615#action_12689615 ]
Jeremy Thomerson commented on WICKET-670:
-----------------------------------------
I just tried using the inspector with a quickstart and it seemed to work okay (1.4-SNAPSHOT). Here's what I did to try it:
1 - change wicket-examples pom.xml to temporarily build as jar (rather than war)
2 - mvn clean install in wicket-examples, locally
3 - add dependency in my quickstart pom on wicket-examples
4 - add inspectorbug to page (i also mounted inspectorpage as bookmarkable - but that's beside the point)
It seems to work.
I would suggest, however, that we move it out of wicket-examples and into a "wicket-inspector" (or similar) subproject of its own. Thoughts?
Could we do this with 1.4? Or since we're in RC already, should it wait to 1.5? I don't think that it would require any API changes - since it seems like you can't use it in your app now anyway without rebuilding wicket-examples on your own.
> Bring back the inspector!
> -------------------------
>
> Key: WICKET-670
> URL: https://issues.apache.org/jira/browse/WICKET-670
> Project: Wicket
> Issue Type: Wish
> Components: wicket
> Affects Versions: 1.4-M1
> Reporter: Jonathan Locke
> Priority: Minor
> Fix For: 1.5-M1
>
>
> My copy of the inspector is completely broken. It's a shame that this useful tool is not really supported anymore. It gives people a sense of confidence when they can navigate their wicket session and see all the components with the inspector.
> To bring the inspector back, we could do the following things:
> 1. fix the inspector
> - it needs to factor out the stack trace metadata so sizes of things are more accurate
> - my inspector causes every page viewed after using it to fail with a page expired exception (!)
> 2. add a security setting setInspectorEnabled() which defaults to false (disabled) and unless
> the inspector is explicitly enabled, the constructor of every publicly accessible bookmarkable
> page in the inspector package throws an IllegalStateException() with an explanation of what
> you must do to safely use the inspector in your application (add security to the pages via
> wicket-auth-roles or some other means and call setInspectorEnabled(true)).
> then we can all enjoy the return of the inspector!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.