You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org> on 2023/07/11 09:24:31 UTC
[GitHub] [age] MuhammadTahaNaveed commented on a diff in pull request #1022: Merge PG13 version 1.3.0 into the master branch
MuhammadTahaNaveed commented on code in PR #1022:
URL: https://github.com/apache/age/pull/1022#discussion_r1259451064
##########
.github/workflows/installcheck.yml:
##########
@@ -0,0 +1,52 @@
+name: PG13 Build / Regression
Review Comment:
duplicate workflow
##########
age--1.3.0.sql:
##########
@@ -47,6 +48,7 @@ CREATE DOMAIN label_id AS int NOT NULL CHECK (VALUE > 0 AND VALUE <= 65535);
CREATE DOMAIN label_kind AS "char" NOT NULL CHECK (VALUE = 'v' OR VALUE = 'e');
CREATE TABLE ag_label (
+
Review Comment:
extra line
##########
src/backend/parser/cypher_clause.c:
##########
@@ -283,17 +290,24 @@ static Query *transform_cypher_call_stmt(cypher_parsestate *cpstate,
static Query *transform_cypher_call_subquery(cypher_parsestate *cpstate,
Review Comment:
duplicate function header `transform_cypher_call_stmt` and `transform_cypher_call_subquery`
##########
src/backend/parser/cypher_clause.c:
##########
@@ -283,17 +290,24 @@ static Query *transform_cypher_call_stmt(cypher_parsestate *cpstate,
static Query *transform_cypher_call_subquery(cypher_parsestate *cpstate,
cypher_clause *clause);
+//call...[yield]
+static Query *transform_cypher_call_stmt(cypher_parsestate *cpstate,
+ cypher_clause *clause);
+static Query *transform_cypher_call_subquery(cypher_parsestate *cpstate,
+ cypher_clause *clause);
Review Comment:
duplicate function header `transform_cypher_call_stmt` and `transform_cypher_call_subquery`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org