You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/06/11 17:08:12 UTC

[bookkeeper] branch master updated: Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new fa58c9a  Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level
fa58c9a is described below

commit fa58c9ac7b6efd95424319238993e8eb62fa6aa3
Author: Andrey Yegorov <ay...@salesforce.com>
AuthorDate: Mon Jun 11 10:08:03 2018 -0700

    Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with debug level, some of them useful for troubleshooting at info/warn level
    
    (bug W-3976846)
    
    Descriptions of the changes in this PR:
    
    Changed log level of one line from debug to info
    
    ### Motivation
    
    Useful for troubleshooting of prod issue, don't want to have debug log enabled in prod all the time.
    
    ### Changes
    
    Changed log level of one line from debug to info
    
    Master Issue: #1500
    
    Author: Andrey Yegorov <ay...@salesforce.com>
    
    Reviewers: Jia Zhai <None>, Sijie Guo <si...@apache.org>
    
    This closes #1501 from dlg99/fix/pendingreadop-log, closes #1500
---
 .../src/main/java/org/apache/bookkeeper/client/PendingReadOp.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
index 3852078..a6ffd32 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
@@ -209,9 +209,9 @@ class PendingReadOp implements ReadEntryCallback, SafeRunnable {
                             lh.ledgerId, eId, host);
                 }
             } else {
-                if (LOG.isDebugEnabled()) {
-                    LOG.debug(errMsg + " while reading L{} E{} from bookie: {}",
-                            lh.ledgerId, eId, host);
+                if (LOG.isInfoEnabled()) {
+                    LOG.info("{} while reading L{} E{} from bookie: {}",
+                            errMsg, lh.ledgerId, eId, host);
                 }
             }
         }

-- 
To stop receiving notification emails like this one, please contact
sijie@apache.org.