You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/11 18:48:28 UTC
Review Request 59198: Added CHANGELOG note that 1.3.0 and 1.2.1
masters ignore old agents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59198/
-----------------------------------------------------------
Review request for mesos and Adam B.
Repository: mesos
Description
-------
Added CHANGELOG note that 1.3.0 and 1.2.1 masters ignore old agents.
Diffs
-----
CHANGELOG 31c21e9a69a6e11429b58a7eddecf7746a284530
Diff: https://reviews.apache.org/r/59198/diff/1/
Testing
-------
Visual inspection, no functional change.
Thanks,
Neil Conway
Re: Review Request 59198: Documented that Mesos 1.3.0,
1.2.1 don't allow old agents to register.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59198/#review174730
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On May 11, 2017, 2:10 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59198/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 2:10 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.
>
>
> Diffs
> -----
>
> CHANGELOG 31c21e9a69a6e11429b58a7eddecf7746a284530
> docs/upgrades.md 74e74642b411eefb737d575b89a1f206cae62b46
>
>
> Diff: https://reviews.apache.org/r/59198/diff/4/
>
>
> Testing
> -------
>
> Visual inspection, no functional change.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59198: Documented that Mesos 1.3.0,
1.2.1 don't allow old agents to register.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59198/
-----------------------------------------------------------
(Updated May 11, 2017, 9:10 p.m.)
Review request for mesos and Adam B.
Changes
-------
Address review comments.
Repository: mesos
Description
-------
Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.
Diffs (updated)
-----
CHANGELOG 31c21e9a69a6e11429b58a7eddecf7746a284530
docs/upgrades.md 74e74642b411eefb737d575b89a1f206cae62b46
Diff: https://reviews.apache.org/r/59198/diff/4/
Changes: https://reviews.apache.org/r/59198/diff/3-4/
Testing
-------
Visual inspection, no functional change.
Thanks,
Neil Conway
Re: Review Request 59198: Documented that Mesos 1.3.0,
1.2.1 don't allow old agents to register.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59198/#review174722
-----------------------------------------------------------
Couple more nits, then we can ship-it
CHANGELOG
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/59198/#comment247939>
Still mixing `> 1.0` and `pre-1.0`, so either `s/pre-1.0/0.x/g` or `s/pre-1.0/< 1.0/` or `s/> 1.0/1.1+/`
docs/upgrades.md
Line 278 (original), 278 (patched)
<https://reviews.apache.org/r/59198/#comment247940>
Ditto on `> 1.0` and `pre-1.0`.
docs/upgrades.md
Lines 50 (patched)
<https://reviews.apache.org/r/59198/#comment247941>
Should we add the same thing to 1.2.x (with a special note that it only applies to `1.2.1+`)?
- Adam B
On May 11, 2017, 12:47 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59198/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 12:47 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.
>
>
> Diffs
> -----
>
> CHANGELOG 31c21e9a69a6e11429b58a7eddecf7746a284530
> docs/upgrades.md 74e74642b411eefb737d575b89a1f206cae62b46
>
>
> Diff: https://reviews.apache.org/r/59198/diff/3/
>
>
> Testing
> -------
>
> Visual inspection, no functional change.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59198: Documented that Mesos 1.3.0,
1.2.1 don't allow old agents to register.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59198/
-----------------------------------------------------------
(Updated May 11, 2017, 7:47 p.m.)
Review request for mesos and Adam B.
Changes
-------
Address review comments.
Repository: mesos
Description
-------
Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.
Diffs (updated)
-----
CHANGELOG 31c21e9a69a6e11429b58a7eddecf7746a284530
docs/upgrades.md 74e74642b411eefb737d575b89a1f206cae62b46
Diff: https://reviews.apache.org/r/59198/diff/3/
Changes: https://reviews.apache.org/r/59198/diff/2-3/
Testing
-------
Visual inspection, no functional change.
Thanks,
Neil Conway
Re: Review Request 59198: Documented that Mesos 1.3.0,
1.2.1 don't allow old agents to register.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59198/#review174713
-----------------------------------------------------------
A few thoughts
CHANGELOG
Lines 51-52 (patched)
<https://reviews.apache.org/r/59198/#comment247929>
Can we refer to "pre-1.0" as `0.x`?
CHANGELOG
Lines 52 (patched)
<https://reviews.apache.org/r/59198/#comment247930>
Interoperability between 1.0 masters and 0.28 agents was supported, during live upgrade.
CHANGELOG
Lines 300 (patched)
<https://reviews.apache.org/r/59198/#comment247928>
s/1.3.0/1.2.1/ ?
- Adam B
On May 11, 2017, 11:58 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59198/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 11:58 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.
>
>
> Diffs
> -----
>
> CHANGELOG 31c21e9a69a6e11429b58a7eddecf7746a284530
> docs/upgrades.md 74e74642b411eefb737d575b89a1f206cae62b46
>
>
> Diff: https://reviews.apache.org/r/59198/diff/2/
>
>
> Testing
> -------
>
> Visual inspection, no functional change.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 59198: Documented that Mesos 1.3.0,
1.2.1 don't allow old agents to register.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59198/
-----------------------------------------------------------
(Updated May 11, 2017, 6:58 p.m.)
Review request for mesos and Adam B.
Changes
-------
Update `upgrades.md`
Summary (updated)
-----------------
Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.
Repository: mesos
Description (updated)
-------
Documented that Mesos 1.3.0, 1.2.1 don't allow old agents to register.
Diffs (updated)
-----
CHANGELOG 31c21e9a69a6e11429b58a7eddecf7746a284530
docs/upgrades.md 74e74642b411eefb737d575b89a1f206cae62b46
Diff: https://reviews.apache.org/r/59198/diff/2/
Changes: https://reviews.apache.org/r/59198/diff/1-2/
Testing
-------
Visual inspection, no functional change.
Thanks,
Neil Conway