You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by manuiiit <gi...@git.apache.org> on 2015/08/06 11:40:14 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8711: public_ip type resource ...
GitHub user manuiiit opened a pull request:
https://github.com/apache/cloudstack/pull/662
CLOUDSTACK-8711: public_ip type resource count for an account is not decremented upon IP range deletion
Probleam:
--------------------------
When you add an IP range and associate it to an account then resource count of public_ip will be updated to the range length.
After some time try to delete this range and the resource count of public_up for this account is not descremented and is causing account not to add any more public IPs to it once it reaches the resource limit.
RCA:
----------------
We were not decrement the count while deleting the IP range that was associated to an account.
Fix:
-------------
Up on deletion we are decrementing the resource count for public_up now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuiiit/cloudstack pull-14
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/662.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #662
----
commit 865623fd1edd0d2a5adb9c6be2cd9c9eab9b32db
Author: Damodar <da...@citrix.com>
Date: 2014-11-18T11:42:28Z
Bug-Id: CS-27335: public_ip type resource count for an account is not decremented upon IP range deletion
Reviewed-By: Kishan/Bharat
Signed-off-by: Maneesha.P <ma...@citrix.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8711: public_ip type resource ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/662#issuecomment-129040085
Build failure is not related to this change. Code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8711: public_ip type resource ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8711: public_ip type resource ...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/662#issuecomment-129323691
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---