[GitHub] [flink] meetjunsu commented on a change in pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

[GitBox <gi...@apache.org>]

meetjunsu commented on a change in pull request #17542:
URL: https://github.com/apache/flink/pull/17542#discussion_r735603151



##########
File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
##########
@@ -141,6 +163,11 @@ private FieldWriter createWriter(LogicalType t, Type type) {
         public void write(RowData row, int ordinal) {
             recordConsumer.addBoolean(row.getBoolean(ordinal));
         }
+
+        @Override
+        public void write(Object value) {
+            recordConsumer.addBoolean((boolean) value);

Review comment:
       `null` will be filtered in MapWriter and ArrayWriter




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org