You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/31 16:19:52 UTC
[GitHub] [arrow-rs] matthewmturner opened a new issue #1113: Implement dyn comparison kernels
matthewmturner opened a new issue #1113:
URL: https://github.com/apache/arrow-rs/issues/1113
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Following the design set in #1074 we would like to add the remaining dynamic comparison kernels.
**Scalar**
- [ ] lt_dyn_scalar
- [ ] lt_eq_dyn_scalar
- [ ] gt_dyn_scalar
- [ ] gt_eq_dyn_scalar
- [ ] neq_dyn_scalar
**UTF8 Scalar**
- [ ] lt_dyn_utf8_scalar
- [ ] lt_eq_dyn_utf8_scalar
- [ ] gt_dyn_utf8_scalar
- [ ] gt_eq_dyn_utf8_scalar
- [ ] neq_dyn_utf8_scalar
**Boolean**
- [ ] lt_dyn_bool_scalar
- [ ] lt_eq_dyn_bool_scalar
- [ ] gt_dyn_bool_scalar
- [ ] gt_eq_dyn_bool_scalar
- [ ] neq_dyn_bool_scalar
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] matthewmturner commented on issue #1113: Implement dyn scalar comparison kernels
Posted by GitBox <gi...@apache.org>.
matthewmturner commented on issue #1113:
URL: https://github.com/apache/arrow-rs/issues/1113#issuecomment-1003566690
> > @alamb @liukun4515
>
> >
>
> > I am submitting a bunch of the PRs now branching off my existing `eq_dyn_scalar` branch. The PRs now currently show all the changes because we havent merged that one in to master yet. Im hoping once that is merged i can simply rebase and these will be good to go.
>
>
>
> @matthewmturner https://github.com/apache/arrow-rs/pull/1074 has been merged, you can rebase other prs, but I think we should merge the prs one by one and reduce the conflict. @alamb
Agree. I was expecting to do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] matthewmturner commented on issue #1113: Implement dyn scalar comparison kernels
Posted by GitBox <gi...@apache.org>.
matthewmturner commented on issue #1113:
URL: https://github.com/apache/arrow-rs/issues/1113#issuecomment-1003503606
@alamb @liukun4515
I am submitting a bunch of the PRs now branching off my existing `eq_dyn_scalar` branch. The PRs now currently show all the changes because we havent merged that one in to master yet. Im hoping once that is merged i can simply rebase and these will be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] liukun4515 commented on issue #1113: Implement dyn scalar comparison kernels
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1113:
URL: https://github.com/apache/arrow-rs/issues/1113#issuecomment-1003562457
> @alamb @liukun4515
>
> I am submitting a bunch of the PRs now branching off my existing `eq_dyn_scalar` branch. The PRs now currently show all the changes because we havent merged that one in to master yet. Im hoping once that is merged i can simply rebase and these will be good to go.
@matthewmturner https://github.com/apache/arrow-rs/pull/1074 has been merged, you can rebase other prs, but I think we should merge the prs one by one and reduce the conflict. @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb closed issue #1113: Implement dyn scalar comparison kernels
Posted by GitBox <gi...@apache.org>.
alamb closed issue #1113:
URL: https://github.com/apache/arrow-rs/issues/1113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] matthewmturner commented on issue #1113: Implement dyn scalar comparison kernels
Posted by GitBox <gi...@apache.org>.
matthewmturner commented on issue #1113:
URL: https://github.com/apache/arrow-rs/issues/1113#issuecomment-1003508119
Going to stop here at the scalar kernels to make sure all good. If this approach is good ill do the utf8 and bool kernels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org