You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by gorkem <gi...@git.apache.org> on 2015/10/21 23:33:50 UTC
[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...
GitHub user gorkem opened a pull request:
https://github.com/apache/cordova-lib/pull/328
CB-9736 - Extra main activity generated when an android package name specified
Removes the old package name after the new one is created. If the package
name is different
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gorkem/cordova-lib CB-9736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #328
----
commit 071eccd7eb33b61fe9dd706dfb520de10bfcfc83
Author: Gorkem Ercan <go...@gmail.com>
Date: 2015-10-21T21:32:08Z
CB-9736 - Extra main activity generated when an android package name is specified
Removes the old package name after the new one is created. If the package
name is different
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/328#issuecomment-150371632
This functionality is moving to the platforms themselves. For this fix to work in android@5.0+, you should look to add it to https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/prepare.js#L156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/328
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...
Posted by gorkem <gi...@git.apache.org>.
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/328#issuecomment-150394486
@stevengill Yes, created CB-9844 to follow up. This one is still valid for fixing older android engines though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9736 - Extra main activity generated ...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/328#issuecomment-150461925
Definitely. Thanks!
On Thu, Oct 22, 2015 at 5:27 PM, Gorkem Ercan <no...@github.com>
wrote:
> @stevengill <https://github.com/stevengill> Yes, created CB-9844 to
> follow up. This one is still valid for fixing older android engines though.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-lib/pull/328#issuecomment-150394486>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org