[GitHub] [dolphinscheduler] ruanwenjun commented on a change in pull request #6283: [Fix-6072][common] Remove Generic method JsonUtils.toMap

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #6283:
URL: https://github.com/apache/dolphinscheduler/pull/6283#discussion_r712684139



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/model/TaskNode.java
##########
@@ -393,7 +394,9 @@ public void setPreTaskNodeList(List<PreviousTaskNode> preTaskNodeList) {
     }
 
     public String getTaskParams() {
-        Map<String, Object> taskParams = JSONUtils.toMap(this.params, String.class, Object.class);
+//        Map<String, Object> taskParams = JSONUtils.toMap(this.params, String.class, Object.class);

Review comment:
       Please remove the unused code

##########
File path: dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/JSONUtilsTest.java
##########
@@ -199,8 +203,6 @@ public void testToMap() {
 
         Assert.assertNull(JSONUtils.toMap("3"));

Review comment:
       It seems you need to remove this test method




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org